Mozilla Firefox

  1. Bug #192092
  2. Comment #22

Comment 22 for bug 192092

Revision history for this message
In , Gavin Sharp (gavin-sharp) wrote :

Comment on attachment 689087
patch version 2

Code-wise, this looks good. I think the only suggestions I would make is that we should probably limit this behavior to Linux somehow (probably by using an #ifdef XP_GNOME like the one in browser-sets.inc).

I don't know the answers to ithinc's concerns, though (about the desired behavior for ctrl+shift+home/end, and possible conflict with other shortcuts) - we should sort that out before landing this.