Comment 23 for bug 1131664

Revision history for this message
bluedxca93 (bluedxca93) wrote : Re: [Bug 1131664] Re: Patch the menus of the 'Calculator', 'Document Viewer' and 'System Settings' apps to fit with Unity

Hi,
will try this patch soon.
It seems to be nearly my patche + adding unity support. I hope my
patch was a help.

I think in evince there is one big problem:
1) the menubar schould not be visible in fullscreen or presentation
mode and fix the possible fals re arranging of the menubar-/ toolbars
when leaving those.

I think the importance of your second bug is currently low. When
trusty will be stable there will be an other version than evince 3.10
so there will be a new patch.

I will test if your third bug also affects cinnamon. If it is so i
will find a way to patch it. Otherwise it's unity specific and i can`t
use unity in virtualbox with cinnamon installed.

The file-roller patch will took more time to create, i'm sure . But
perhaps you will make it. I've sucessfully patched the uploaded
source folder which compiles fine on my PC , but every time i want to
create a patch it fails for unknown reasons.

I could create some langugage file patches if you want that. 'can
understand english french and german, and i think i would be able to
re- insert some code for other european languages too.

For the moment apart from epiphany, only the main program binarys are
really different from the not patched ones. In file-roller ther is an
ugly attach menubar code which should be deleted soon )= . I'will
perhaps take a look at the gome main games section ( as gnome-mine)
soon. I'm not an programmer and i can't write anything in C or python
but the code changes for the menubar are nearly normally readable. I
now also how to wirte gtk3 css files and this is really similar.

regards bluedxca93

2013/11/14, Marc Deslauriers <email address hidden>:
> Here's a debdiff for evince for saucy I worked on.
>
> What's left to do:
> - port it to trusty
> - make it use gtk-shell-shows-menubar instead of XDG_CURRENT_DESKTOP so it
> can be upstreamed
> - Fix a bug where about 1 in 5 launches results in the menu items being
> greyed out. Not sure if this is an issue with the patch though as with
> UBUNTU_MENUPROXY it works every time.
>
> ** Patch added: "evince_3.10.0-0ubuntu2.1~md1.debdiff"
>
> https://bugs.launchpad.net/ubuntu/+source/evince/+bug/1131664/+attachment/3908909/+files/evince_3.10.0-0ubuntu2.1%7Emd1.debdiff
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1131664
>
> Title:
> Patch the menus of the 'Calculator', 'Document Viewer' and 'System
> Settings' apps to fit with Unity
>
> Status in Ayatana Design:
> Fix Committed
> Status in File Roller:
> New
> Status in “evince” package in Ubuntu:
> Triaged
> Status in “file-roller” package in Ubuntu:
> Triaged
> Status in “gnome-calculator” package in Ubuntu:
> Fix Released
> Status in “gnome-control-center” package in Ubuntu:
> Fix Released
>
> Bug description:
> When fixing this bug, also take a look at bug #1130722 at the same
> time if possible.
>
>
> ----------------------------------------------------------------------------------
>
> In Raring, the 'Calculator' app should have the following menu items:
>
> === Edit ===
>
> Copy
> Paste
> ---------
> Undo
> Redo
> ---------
> Preferences
> ---------
> Quit
>
> === Mode ===
>
> Basic
> Advanced
> Financial
> Programming
>
> === Help ===
>
> Contents
> About
>
>
> ------------------------------------------------------------------------------------
>
> In Raring, the 'System Settings' app should have the following menu
> items:
>
> === Help ===
>
> Contents
> [Optional link to help doc for the currently selected settings panel]
> ---------
> Quit
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions
>