Comment 11 for bug 1970557

Revision history for this message
Rhonda D'Vine (rhonda) wrote :

Timo, can you please elaborate what is missing? Because it's there. If you are just referring that it doesn't use the template then ... sorry to not followed the bureocratic bits to the detail, I'll do that now. I can though understand that not having done that directly would have left more work on your shoulders, I was under the impression that all bits are already in here (and it's not like there are hundreds of comments, so ...)

[ Impact ]

The package can't be used at all in its current state because it doesn't work with one of its central dependencies. It creates a backtrace as seen in the original bug description on simple usage cases.

The bugfix makes the package compatible with the newer version of the dependency.

[ Test Plan ]

 * detailed instructions how to reproduce the bug

See the example code in the bug description, but for convenience I paste it here again:

Create a file "fastapi-test.py" with the following code:

-----
from fastapi import FastAPI

app = FastAPI()

@app.get("/")
async def root():
    return {"Status": "ok"}
-----

Then run that file with python interpreter.

[ Where problems could occur ]

 * Think about what the upload changes in the software. Imagine the change is
   wrong or breaks something else: how would this show up?

The package isn't usable at all right now. It can't get worse than that, frankly speaking.

 * This must '''never''' be "None" or "Low", or entirely an argument as to why
   your upload is low risk.

Well, actually what regression risk could there be for a package not usable at all right now? I would very much assert that this covers a clear "None" because even if the fix wouldn't work (which it does) the package still would just not work and couldn't be in a worse state.

[ Other Info ]

 * Anything else you think is useful to include

I really thought the bug description and the description of the patch should be self-explenatory, and I'm sorry that this assumption seemingly was wrong. My bad.