Comment 27 for bug 588861

Tim Gardner (timg-tpi) wrote :

works with f21121cde6e617b90cd03ce083652ca543004dc2

rtg@zinc:~/linux-2.6$ git bisect good
cc56f7de7f00d188c7c4da1e9861581853b9e92f is first bad commit
commit cc56f7de7f00d188c7c4da1e9861581853b9e92f
Author: Changli Gao <email address hidden>
Date: Wed Nov 4 09:09:52 2009 +0100

    sendfile(): check f_op.splice_write() rather than f_op.sendpage()

    sendfile(2) was reworked with the splice infrastructure, but it still
    checks f_op.sendpage() instead of f_op.splice_write() wrongly. Although
    if f_op.sendpage() exists, f_op.splice_write() always exists at the same
    time currently, the assumption will be broken in future silently. This
    patch also brings a side effect: sendfile(2) can work with any output
    file. Some security checks related to f_op are added too.

    Signed-off-by: Changli Gao <email address hidden>
    Signed-off-by: Jens Axboe <email address hidden>

:040000 040000 c10964cc42af214af80ecfd5cc3e9e873c09b8d5 a1fecaea1c9a54c62471cdfe3b6540ca6619e2cb M fs