Comment 9 for bug 1267564

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi,
while cleaning old bugs I have checked how this behaves as of today and I found that it seems to have better fallback mechanisms now.

If no user/email is set but there is a valid hostname it becomes root@hostname like
  Author: root <root@i.lxd>
But then we had other bugs (in other packages) about broken behavior if the hostname is no FQDN, but even that seems to be fine in etckeeper nowadays, it becomes automatically just the IP
  Author: root <root@192.168.122.225>

Also it actually tries to look up both - not only the config of root, but in case of e.g. sudo/su those of the user that invokes it. But then on unattended upgrades and such it is just root (no sudo), and that is when the above fallback even if no user or hostname is set happen.

And even worst case (= commit still fails for some reason) this has become non-breaking in 1.14 via [1] which isn't perfect as no commit happened in that case, but it makes it less impactful to the overall updating of the system. After all this will after a few hours be still catched by the daily timer that commits to git as well.

I'll set this to Fix Released based on that, but if there are still conditions left that make it break nowadays please re-open and we can have a look how to harden that edge case then.

[1]: https://salsa.debian.org/debian/etckeeper/-/commit/1b70e83dddcafbcbea84fc55a6396e4876a9a0c4