Comment 11 for bug 1142947

Revision history for this message
John S. Gruber (jsjgruber) wrote :

Thanks, Brian, for looking at this and offering to look at it again before Raring release.

I'm sure you are right that not many people are presently affected--firefox is widely used and chromium-browser uses its own Javascript engine. For those using straight webkit I think only the i386 architecture doesn't use the Low Level Interpreter and therefore only it is affected. If the LLINT is enabled the present code already creates the structure in the DFG::ShouldProfile case. (See line 811 of Source/JavaScriptCore/jit/JIT.cpp. for where the situation is categorized).

I'm maintaining Lernid and the current Lernid and from the current classes I'd say Lernid isn't used with youtube often (if at all). However I have readied a release for support of ubuntuonair which uses hangouts, and therefore youtube. The first time I tested it I got this crash. I can't release Lernid with this bug outstanding in the soon-to-be current Ubuntu release. I gather this release is also in quantal-proposed.

Please see https://bugs.launchpad.net/lernid/+bug/1130454 filed by an ubuntuonair organizer and Liz from the Ubuntu classroom team. The blueprint is at https://blueprints.launchpad.net/lernid/+spec/support-ubuntu-onair .

I believe this problem will be resolved when upstream releases r144137 for gtk. It makes the relevant test include the additional alternative, if I read it correctly. It's too complex for me to feel comfortible proposing for cherry picking.

I've added the patch headers you've requested and hope that they are alright.