Comment 1 for bug 1311984

Revision history for this message
Michael Terry (mterry) wrote :

- The source package comes with some odd build artifacts still in it. Like debian/*.debhelper.log, debian/substvars, and a broken libefence.so symlink in the toplevel. Not actual problems. But seems sloppy.

- There is a compile warning that seems problematic, in that it indicates the XSI version of strerror_r is being used, but the code is expecting the GNU one (see the man page for strerror_r):

page.c: In function 'stringErrorReport':
page.c:46:2: warning: return makes pointer from integer without a cast [enabled by default]
  return strerror_r(errno,(char *)err_message,128);
  ^

- Also needs a team bug subscriber for whichever team will look after this in Ubuntu.

- I like the tests being run on build! Besides the above comments, looks good.