Ubuntu
efax-gtk package

  1. Bug #155950
  2. Comment #4

Comment 4 for bug 155950

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Many thanks for your work Nicolas. Its very good but there are still few things that I would correct:

1) Good work in cleaning the debdiff, but you should also remove these:

diff -u efax-gtk-3.0.15/config.guess efax-gtk-3.0.15/config.guess
diff -u efax-gtk-3.0.15/config.sub efax-gtk-3.0.15/config.sub

2) Instead of just saying "Merged the changes from revision 3.0.14-1ubuntu1" I would explicitly list them.
I think its easier to keep track of them for the future than to oblige the next reviewer to search for them.

3) Instead of "Update the debian/menu according to the previus version of the package" I would word it as "Reverse incorrect debian maintainer change to debian/menu to the ubuntu version one"

Once corrected please subscribe u-u-s for sponsoring, set status as confirmed and de-assign yourself (see https://wiki.ubuntu.com/MOTU/Sponsorship/SponsorsQueue).