The valueContainsFlag method should be removed again. If it would have been kept, the following would have had to be fixed:
- Why is the type of 'value' long and not int?
- Missing @return description.
- Typo: Convienience (please check why you didn't see an error underline from the spell checker)
(In reply to Eclipse Genie from comment #53) /git.eclipse. org/r/50125 was merged to [master]. git.eclipse. org/c/platform/ eclipse. platform. swt.git/ commit/ ?id=3db87a8763e 3fd3f931295da16 5ddee8363a7b16
> Gerrit change https:/
> Commit:
> http://
>
The Widget# valueContainsFl ag(..) doesn't meet SWT's coding style and quality standards:
- The standard idiom in SWT is this:
if ((keymask & (OS.GDK_MOD1_MASK | OS.GDK_SHIFT_MASK ltSelection( );
| OS.GDK_CONTROL_MASK | OS.GDK_SUPER_MASK
| OS.GDK_META_MASK | OS.GDK_HYPER_MASK)) != 0) {
sendTreeDefau
}
Also note the position of the '{'.
The valueContainsFlag method should be removed again. If it would have been kept, the following would have had to be fixed:
- Why is the type of 'value' long and not int?
- Missing @return description.
- Typo: Convienience (please check why you didn't see an error underline from the spell checker)