Comment 49 for bug 586910

Revision history for this message
In , Akurtakov (akurtakov) wrote :

(In reply to Leo Ufimtsev from comment #41)
> I have a ~Work-in-progress~ patch here:
> (NOT FULLY READY YET):
> https://git.eclipse.org/r/#/c/49702
>
> There are 2 issues:
>
> 1) 11 year workaround that steals focus that is no longer relevant. (Removed
> it).
> see:
> git show 300ace8e3eaec6136b4861feec65efae8fe149fc

Having this removed in separate commit is good idea as this is a must do stuff while the rest is not yet decided and we can push it as soon as devel opens.

>
> 2) MouseDoubleClick event comes after DefaultSelection. Platform UI (quite
> logically) expects DefaultSelection to come after MouseDoubleClick.
> If I manually delay this event by 50ms then all works well.
>
> Now I'm looking for a better way to solve it than a 50ms delay.
> What I have in mind at the moment is :
> a. Not listen to ROW_ACTIVATION at all. Instead manually trigger
> defaultSelection after DoubleClick event occurred and get selection manually.
>
> b. Write some thread-wait mechanism that slows down DefaultSelection till
> after Double-click event went through.
>
> I'm researching which of those works best.

a) sounds better option to me

>
> Any thoughts/tips/advise is welcomed.