Comment 12 for bug 93921

Revision history for this message
Theodore Ts'o (tytso) wrote :

Well, some formats allow for more complicated checks, and others don't. LUKS is really bad, in that it only uses 4 bytes at the beginning of the disk, and nothing else. And the formatter in question, NTFS, isn't under our control. So with blkid, I make a policy that probers that are more sophisticated should try first, and probers which are really stupid (and in the case of LUKS, the probe routine can only be stupid, because everything after the magic number is apparently random encrypted garbage :-).

I agree that in general, it's better to make the probing routines more sophisticated, and to fix the broken tool if we can. But short of telling the whole world not to use Windows NT (I am King Canute! I can command the tide from coming in! :-), we can't really do the latter, and in this case, the format prevents us from doing the former. So changing the order to hide the LUKS prober behind more sophisticated probing routines does make sense.