Comment 10 for bug 307961

Revision history for this message
dag (dag-wieers) wrote : Re: [Bug 307961] Re: Disk total stats are double

On Mon, 15 Dec 2008, Noel J. Bergman wrote:

>> If you look at the plugin you will see what I mean.
>
> Yes, I had looked at it. And now I have a patch for you, which I'm
> attaching.
>
> The patch, itself, just enhances the regex to filter out partitions when
> computing the total stat.

Hi Noel,

Thanks for the patch, I modified it in 3 ways:

  - Fix it for the other dstat_disk* plugins (it is possible that for the
    2.4 kernels the same changes is being made at some point)

  - Fixed the discover functions as well (we do not want /dev/sda1 to
    appear in the full list)

  - Make sure all devices are being filtered (eg. sdaa1)

I committed the patch to subversion and it will be part of 0.6.10 when it
is released. Thanks a lot for the feedback and patch !

--
-- dag wieers, <email address hidden>, http://dag.wieers.com/ --
[Any errors in spelling, tact or fact are transmission errors]