Comment 65 for bug 2022390

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Lucas. Here's my review.

I found it a bit strange that we're dropping all d/changelog entries (related to the -0ubuntuX releases), but I guess that's OK...? I mean, I see now that you have done the same thing for containerd and docker.io, and since I reviewed those changes and gave my OK, maybe this is something that we already discussed and I'm just not remembering?

Either way, packaging-wise the changes mostly LGTM, but I have a question about the following d/changelog entry:

+ - d/tests/{checkpoint,integration}: remove since they depend on the
+ runc binary package which is not provided by this source package
+ anymore.

I couldn't find these changes in the debdiff. Maybe you forgot to include them?