- d/changelog changes: Works for me. As we discussed previously, I'm fine with your final decision since you're the one who will be taking care of the package.
Meanwhile, I was able to build the package locally and found some final nits:
- lintian is telling me about missing NOTICE files for the Apache license:
Thanks, Lucas.
- d/changelog changes: Works for me. As we discussed previously, I'm fine with your final decision since you're the one who will be taking care of the package.
Meanwhile, I was able to build the package locally and found some final nits:
- lintian is telling me about missing NOTICE files for the Apache license:
E: docker.io source: missing- notice- file-for- apache- license [cli/NOTICE] notice- file-for- apache- license [engine/NOTICE] notice- file-for- apache- license [engine/ vendor/ code.cloudfound ry.org/ clock/NOTICE] notice- file-for- apache- license [swarmkit/ vendor/ code.cloudfound ry.org/ clock/NOTICE]
E: docker.io source: missing-
E: docker.io source: missing-
E: docker.io source: missing-
I think this is a side effect of the docker-docs migration.
The only binary package generated by docker.io now is golang- github- docker- docker- dev. It installs successfully.
There are no dep8 tests in the package anymore, as they've been moved to docker.io-app.
The rest of the package LGTM, so I'm giving it a +1 already. Feel free to upload once you address the lintian errors above.