2012-06-17 05:08:03 |
bodhi.zazen |
bug |
|
|
added bug |
2012-06-17 05:08:03 |
bodhi.zazen |
attachment added |
|
patch display-dhammapada.1 https://bugs.launchpad.net/bugs/1014195/+attachment/3193229/+files/display-dhammapada-0.23.1.patch |
|
2012-06-17 05:08:54 |
bodhi.zazen |
attachment added |
|
patch for display-dhammapada.1.in https://bugs.launchpad.net/ubuntu/+source/display-dhammapada/+bug/1014195/+attachment/3193230/+files/display-dhammapada-0.23.1.in.patch |
|
2012-06-17 05:10:13 |
bodhi.zazen |
attachment added |
|
patch display-dhammapada.c https://bugs.launchpad.net/ubuntu/+source/display-dhammapada/+bug/1014195/+attachment/3193231/+files/display-dhammapada-0.23.c.patch |
|
2012-06-17 08:25:21 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
2012-06-17 08:25:29 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Review Team |
2012-06-17 14:47:52 |
bodhi.zazen |
attachment removed |
patch display-dhammapada.1 https://bugs.launchpad.net/ubuntu/+source/display-dhammapada/+bug/1014195/+attachment/3193229/+files/display-dhammapada-0.23.1.patch |
|
|
2012-06-17 14:48:19 |
bodhi.zazen |
attachment removed |
patch for display-dhammapada.1.in https://bugs.launchpad.net/ubuntu/+source/display-dhammapada/+bug/1014195/+attachment/3193230/+files/display-dhammapada-0.23.1.in.patch |
|
|
2012-06-17 14:49:49 |
bodhi.zazen |
attachment added |
|
patch display-dhammapada.1 https://bugs.launchpad.net/ubuntu/+source/display-dhammapada/+bug/1014195/+attachment/3193655/+files/display-dhammapada-0.23.1.patch |
|
2012-06-17 14:52:23 |
bodhi.zazen |
attachment added |
|
patch display-dhammapada.1.in https://bugs.launchpad.net/ubuntu/+source/display-dhammapada/+bug/1014195/+attachment/3193656/+files/display-dhammapada-0.23.1.in.patch |
|
2012-06-17 18:30:40 |
Thomas Ward |
description |
I just finished packaging display-dhammapada for Fedora and so went through this package.
1. The man page needs updating as it contains undefined macros and dead links / url.
Here are the patches for display-dhammapada.1 :
--- display-dhammapada-0.23/display-dhammapada.1 2003-08-13 11:56:31.000000000 -0600
+++ display-dhammapada-0.23-fedora/display-dhammapada.1 2012-06-15 22:00:40.090200049 -0600
@@ -1,6 +1,5 @@
.\" -*- coding: UTF-8 -*-
-.DD April 13, 2003
-.TH DISPLAY-DHAMMAPADA 1 "late 20th - early 21th century"
+.TH DISPLAY-DHAMMAPADA 1 "April 2003" "0.23" "display-dhammapada man page"
.SH NAME
display-dhammapada \- display a verse from the Dhammapada
.SH SYNOPSIS
@@ -73,7 +72,7 @@
.fi
.\" $bash1$ display-dhammapada -r all |perl -0777 -pe 's/\n\s*\n\s*\n/\n%\n/g' >~/.kde/share/apps/amor/tips
-.Ed
+.P
Then start amor K->Toys->Amor, right click on amor animation, select "Options" and check "Show random tips".
.SH FILES
.I /usr/local/share/display-dhammapada/dhammapada-english-transl.txt
@@ -87,11 +86,12 @@
.SH AUTHORS
Program: Copyright \(co 1997-2003 Richard Cepas, placed in the public domain.
.br
-See http://www.angelfire.com/me/rch/dd.html
+See http://unicode.strangled.net/me/rch/dd.html
.P
Richards' English translation of the Dhammapada: Copyright (C) 1993 John
Richards, Pembrokeshire (UK), permission granted for use here.
-See ftp://coombs.anu.edu.au/coombspapers/otherarchives/electronic-buddhist-archives/buddhism-general/e-texts/sutras-translations/dhammapada-english-transl.txt
+./" Old link - See ftp://coombs.anu.edu.au/coombspapers/otherarchives/electronic-buddhist-archives/buddhism-general/e-texts/sutras-translations/dhammapada-english-transl.txt
+See http://eawc.evansville.edu/anthology/dhammapada.htm - John Richards (19.Oct.1993)
.P
Muller's translation of the Dhammapada: Public Domain, used here courtesy of
Project Gutenberg.
And display-dhammapada.1.in :
--- display-dhammapada-0.23/display-dhammapada.1.in 2003-08-13 10:23:50.000000000 -0600
+++ display-dhammapada-0.23-fedora/display-dhammapada.1.in 2012-06-15 22:39:39.631166846 -0600
@@ -1,6 +1,5 @@
.\" -*- coding: UTF-8 -*-
-.DD April 13, 2003
-.TH DISPLAY-DHAMMAPADA 1 "late 20th - early 21th century"
+.TH DISPLAY-DHAMMAPADA 1 "April 2003" "0.23" "display-dhammapada man page"
.SH NAME
display-dhammapada \- display a verse from the Dhammapada
.SH SYNOPSIS
@@ -73,7 +72,7 @@
.fi
.\" $bash1$ display-dhammapada -r all |perl -0777 -pe 's/\n\s*\n\s*\n/\n%\n/g' >~/.kde/share/apps/amor/tips
-.Ed
+.P
Then start amor K->Toys->Amor, right click on amor animation, select "Options" and check "Show random tips".
.SH FILES
.I /usr/share/display-dhammapada/dhammapada-english-transl.txt
@@ -87,11 +86,12 @@
.SH AUTHORS
Program: Copyright \(co 1997-2003 Richard Cepas, placed in the public domain.
.br
-See http://www.angelfire.com/me/rch/dd.html
+See http://unicode.strangled.net/me/rch/dd.html
.P
Richards' English translation of the Dhammapada: Copyright (C) 1993 John
Richards, Pembrokeshire (UK), permission granted for use here.
-See ftp://coombs.anu.edu.au/coombspapers/otherarchives/electronic-buddhist-archives/buddhism-general/e-texts/sutras-translations/dhammapada-english-transl.txt
+.\" Old link - See ftp://coombs.anu.edu.au/coombspapers/otherarchives/electronic-buddhist-archives/buddhism-general/e-texts/sutras-translations/dhammapada-english-transl.txt
+See http://eawc.evansville.edu/anthology/dhammapada.htm - John Richards (19.Oct.1993)
.P
Muller's translation of the Dhammapada: Public Domain, used here courtesy of
-Project Gutenberg.
+Project Gutenberg.
I will add those as attachments.
2. When reviewing the package, the Makefile appears to be intended to be run as root. This is sort of outdated as most packaging is done as users using fakeroot. I had to patch the Makefile for Fedora, you may wish to review this in the .deb
3. You may wish to review the locations of the display-dhammapada .txt files. By default , /usr/lib and /usr/local/lib are used. I am not sure if either are appropriate, so I moved it to /usr/share
in display-dhammapada.c
#define DPPATHNAME "/usr/local/lib/display-dhammapada/dhammapada-english-transl.txt:/usr/lib/display-dhammapada/dhammapada-english-transl.txt:/usr/share/display-dhammapada/dhammapada-english-transl.txt"
#define DPPATHNAME_ALT "/usr/local/lib/display-dhammapada/dhammapada-alternate.txt:/usr/lib/display-dhammapada/dhammapada-alternate.txt:/usr/share/display-dhammapada/dhammapada-alternate.txt"
#define DPPATHNAME_PL "/usr/local/lib/display-dhammapada/dhammapada-polish-transl.txt:/usr/lib/display-dhammapada/dhammapada-polish-transl.txt:/usr/share/display-dhammapada/dhammapada-polish-transl.txt"
4. I think the file examples/xsession should start with a shee-bang
#! /bin/sh
I will report this on Debian as well, not sure how active upstream (from Debian) is ... |
I just finished packaging display-dhammapada for Fedora and so went through this package.
1. The man page needs updating as it contains undefined macros and dead links / url.
I have added those as attachments
2. When reviewing the package, the Makefile appears to be intended to be run as root. This is sort of outdated as most packaging is done as users using fakeroot. I had to patch the Makefile for Fedora, you may wish to review this in the .deb
3. You may wish to review the locations of the display-dhammapada .txt files. By default , /usr/lib and /usr/local/lib are used. I am not sure if either are appropriate, so I moved it to /usr/share
4. I think the file examples/xsession should start with a shee-bang
I will report this on Debian as well, not sure how active upstream (from Debian) is ... |
|
2012-06-17 18:32:36 |
bodhi.zazen |
description |
I just finished packaging display-dhammapada for Fedora and so went through this package.
1. The man page needs updating as it contains undefined macros and dead links / url.
I have added those as attachments
2. When reviewing the package, the Makefile appears to be intended to be run as root. This is sort of outdated as most packaging is done as users using fakeroot. I had to patch the Makefile for Fedora, you may wish to review this in the .deb
3. You may wish to review the locations of the display-dhammapada .txt files. By default , /usr/lib and /usr/local/lib are used. I am not sure if either are appropriate, so I moved it to /usr/share
4. I think the file examples/xsession should start with a shee-bang
I will report this on Debian as well, not sure how active upstream (from Debian) is ... |
I just finished packaging display-dhammapada for Fedora and so went through this package.
1. The man page needs updating as it contains undefined macros and dead links / url.
see below for patchs
patch display-dhammapada.1
patch display-dhammapada.1.in
2. When reviewing the package, the Makefile appears to be intended to be run as root. This is sort of outdated as most packaging is done as users using fakeroot. I had to patch the Makefile for Fedora, you may wish to review this in the .deb
If you wish, I can attach my Makefile as a patch, but, rmp packaging is different from deb, so much of it is defined in the (rpm) .spec
What you will want to look at is
a. Packaging as a user, not root.
b. Ownership and permissions of files.
c. The c-flags. You may or may not wish to update the cflags.
d. The path (see #3) for files.
3. You may wish to review the locations of the display-dhammapada .txt files. By default , /usr/lib and /usr/local/lib are used. I am not sure if either are appropriate, so I moved it to /usr/share
in display-dhammapada.c
See patch display-dhammapada.c
4. I think the file examples/xsession should start with a shee-bang
#! /bin/sh
I will report this on Debian as well, not sure how active upstream (from Debian) is ... |
|
2012-06-17 18:41:11 |
bodhi.zazen |
bug watch added |
|
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677832 |
|
2012-06-17 18:45:38 |
Thomas Ward |
bug task added |
|
display-dhammapada (Debian) |
|
2012-06-17 19:59:07 |
Bug Watch Updater |
display-dhammapada (Debian): status |
Unknown |
New |
|
2012-06-19 15:55:17 |
Thomas Ward |
bug task added |
|
display-dhammapada |
|
2012-06-19 17:05:01 |
Thomas Ward |
display-dhammapada: assignee |
|
bodhi.zazen (bodhi.zazen) |
|
2012-06-19 17:07:56 |
Thomas Ward |
display-dhammapada (Ubuntu): assignee |
|
bodhi.zazen (bodhi.zazen) |
|
2012-06-21 15:36:46 |
bodhi.zazen |
display-dhammapada (Ubuntu): status |
New |
In Progress |
|
2012-06-21 18:50:19 |
Thomas Ward |
display-dhammapada: status |
New |
In Progress |
|
2012-12-19 16:32:11 |
Launchpad Janitor |
branch linked |
|
lp:debian/display-dhammapada |
|
2012-12-19 18:14:17 |
Launchpad Janitor |
display-dhammapada (Ubuntu): status |
In Progress |
Fix Released |
|
2012-12-20 07:31:46 |
Bug Watch Updater |
display-dhammapada (Debian): status |
New |
Fix Released |
|