documentation needs updating

Bug #1014195 reported by bodhi.zazen on 2012-06-17
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
display-dhammapada
Undecided
bodhi.zazen
display-dhammapada (Debian)
Fix Released
Unknown
display-dhammapada (Ubuntu)
Undecided
bodhi.zazen

Bug Description

I just finished packaging display-dhammapada for Fedora and so went through this package.

1. The man page needs updating as it contains undefined macros and dead links / url.

see below for patchs
patch display-dhammapada.1
patch display-dhammapada.1.in

2. When reviewing the package, the Makefile appears to be intended to be run as root. This is sort of outdated as most packaging is done as users using fakeroot. I had to patch the Makefile for Fedora, you may wish to review this in the .deb

If you wish, I can attach my Makefile as a patch, but, rmp packaging is different from deb, so much of it is defined in the (rpm) .spec

What you will want to look at is

a. Packaging as a user, not root.
b. Ownership and permissions of files.
c. The c-flags. You may or may not wish to update the cflags.
d. The path (see #3) for files.

3. You may wish to review the locations of the display-dhammapada .txt files. By default , /usr/lib and /usr/local/lib are used. I am not sure if either are appropriate, so I moved it to /usr/share

in display-dhammapada.c

See patch display-dhammapada.c

4. I think the file examples/xsession should start with a shee-bang

#! /bin/sh

I will report this on Debian as well, not sure how active upstream (from Debian) is ...

Related branches

bodhi.zazen (bodhi.zazen) wrote :

The attachment "patch display-dhammapada.1" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
bodhi.zazen (bodhi.zazen) wrote :

Updated patch, includes change moving to /usr/share/display-dhammapada

bodhi.zazen (bodhi.zazen) wrote :

Updated patch for display-dhammapada.1.in

changes to /usr/share/display-dhammapada

You will want to review display-dhammapada.c and decide if you wish to move the text files from /usr/lib to /usr/share and adjust accordingly.

Thomas Ward (teward) wrote :

Editing description after discussing with bodhi.zazen on IRC.

bodhi.zazen: when you've filed the bug with Debian, please link this bug to that bug. If you do not know how, then posting the debian bug link here will be sufficient until someone can come by and add the Debian bug link.

description: updated
description: updated
Changed in display-dhammapada (Debian):
status: Unknown → New
Thomas Ward (teward) wrote :

Assigned to bodhi.zazen for upstream and Ubuntu at his request (on IRC)

Changed in display-dhammapada:
assignee: nobody → bodhi.zazen (bodhi.zazen)
Changed in display-dhammapada (Ubuntu):
assignee: nobody → bodhi.zazen (bodhi.zazen)
Changed in display-dhammapada (Ubuntu):
status: New → In Progress
Thomas Ward (teward) on 2012-06-21
Changed in display-dhammapada:
status: New → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package display-dhammapada - 1.0-0.1

---------------
display-dhammapada (1.0-0.1) unstable; urgency=low

  * All below mentioned work done by <email address hidden>
  * New upstream version.
  * New upstream maintainer
  - bodhi.zazen <bodhizazen at fedoraproject.org>
  -http://bodhizazen.net/display-dhammapada
  *display-dhammapada.c
  -Changed copyright from Public License to GPL v3
  * Patched display-dhammapada.c
  -Fixed warnings
  -Paul Tagliamonte <email address hidden>
  -Path changed from /usr/local to /usr
  * contrib/gtk-dhammapada.c removed, it no longer compiles
  * short version renamed to dhamma
  * graphical wrapper renamed to xdhamma
  * xdhamma was re-written
  -Uses notify-send rather the xmessage
  -Added icon set for notify-send
  -Able to select translation
  -License GPL V3
  *Makefile re-written
  -Removed script to gpg sign packages
  -Removed script to upload source code
  -Set default prefix to /usr
  -Documents moved to /usr/share/doc/display-dhammapada
  -Translations moved to /usr/share/display-dhammapada
  -configured make to run as a user rather then root
  -set permissions (dir 755 files 644)
  -check if CFLAGS were passed on the command line
  -test and if needed create target (install) directories
  -cleaned dist, clean, and uninstall targets
  *Verse 50 of dhammapada-english-transl.txt
  - "no the shortcomings" changed to
  - "not the shortcomings"
  *Verse 127 in dhammapada-alternate.txt corrected - it was duplicate to 128
  -http://forum.soft32.com/linux2/Bug-169539-Missing-verse-Max-Mueller-\
  translation-ftopict67280.html
  *Information from examples/* added to man page
  -examples/* removed
  *Updated man pages
  -(Closes: #677832)
  -(Closes: LP: #1014195)
  -fixed macros
  -updated reference URL
  *Updated README to include more information
  *Organized the files into sub-directories
  *Added icons for xdhamma (notify-send)
  *copyright file updated

 -- Jakub Nadolny <email address hidden> Mon, 25 Jun 2012 14:05:45 -0600

Changed in display-dhammapada (Ubuntu):
status: In Progress → Fix Released
Changed in display-dhammapada (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.