Comment 11 for bug 12272

Message-ID: <email address hidden>
Date: Tue, 25 Jan 2005 22:38:39 -0800
From: Ryan Murray <email address hidden>
To: Branden Robinson <email address hidden>, <email address hidden>
Subject: Re: Bug#291722: clone 291722, reassign 292224 to discover1

On Tue, Jan 25, 2005 at 03:49:28PM -0500, Branden Robinson wrote:
> * Fix xserver-xfree86's configure script to not die if Discover 1.x's
> discover command segfaults. Thanks to Kyle McMartin for reporting this
> problem and testing the fix.[1]

Yes, that was indeed the problem.

> The submitter of 291722 may want to work with the Discover maintainers to
> identify the cause of the underlying segfault.

ltrace:
ide_detect(0x804c030, 0x804a440, 0x804a480, 0x804bac0, 0xbffff43c <unfinished ...>

strace:
open("/proc/ide/hda/geometry", O_RDONLY) = 5
fstat64(5, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0
mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0xb7fe8000
read(5, 0xb7fe8000, 1024) = -1 EIO (Input/output error)
--- SIGSEGV (Segmentation fault) @ 0 (0) ---
+++ killed by SIGSEGV +++

Apparently discover1 doesn't handle getting read errors too gracefully.