Comment 12 for bug 117180

Revision history for this message
Emmet Hikory (persia) wrote :

Thank you for the continued work to improve desktop-file-validate. This patch applies cleanly, and seems to do many of the right things, but the resulting package does not compile for me. Separately, a few notes:

1) Line 741 of the resulting file compresses an else statement to a single line. Is there a strong reason for this? The typical GNOME practice is to use a separate line excepting when using an else if construction.

2) You probably don't need the definition of fix_encoding around line 924