Comment 3 for bug 1951608

Revision history for this message
Andrea Righi (arighi) wrote :

It looks like it's still broken:

  CC [M] /home/ubuntu/ddcci/ddcci-driver-linux-0.4.1/ddcci/ddcci.o
/home/ubuntu/ddcci/ddcci-driver-linux-0.4.1/ddcci/ddcci.c: In function ‘ddcci_device_remove’:
/home/ubuntu/ddcci/ddcci-driver-linux-0.4.1/ddcci/ddcci.c:1283:24: error: ‘return’ with a value, in function returning void [-Werror=return-type]
 1283 | return -EINVAL;
      | ^
/home/ubuntu/ddcci/ddcci-driver-linux-0.4.1/ddcci/ddcci.c:1273:13: note: declared here
 1273 | static void ddcci_device_remove(struct device *dev)
      | ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:285: /home/ubuntu/ddcci/ddcci-driver-linux-0.4.1/ddcci/ddcci.o] Error 1
make[2]: *** [Makefile:1880: /home/ubuntu/ddcci/ddcci-driver-linux-0.4.1/ddcci] Error 2

This is because ddcci_device_remove() is defined as void in 5.15, but there's a return -EINVAL in the body.

The fix for this is trivial, I'll post another debdiff.