Comment 1 for bug 702026

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

All point checked and sounds a good candidate for Main.

However, I have some build issue trying to rebuilding the tests:
c++ -DHAVE_CONFIG_H -DNDEBUG -c -I. -I. -I../include -I../../config/include \
   -O -I/usr/include/libxml2 -D_REENTRANT -D_XOPEN_SOURCE_EXTENDED -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_BSD_COMPAT -D_OSF_SOURCE -D_POSIX_C_SOURCE=199506L -g -O2 ofconfig.cc
ar cruv libofstd.a oflist.o ofstring.o ofcmdln.o ofconapp.o offname.o ofconsol.o ofthread.o oflogfil.o ofcond.o ofstd.o ofcrc32.o ofdate.o oftime.o ofdatime.o ofconfig.o
a - oflist.o
a - ofstring.o
a - ofcmdln.o
a - ofconapp.o
a - offname.o
a - ofconsol.o
a - ofthread.o
a - oflogfil.o
a - ofcond.o
a - ofstd.o
a - ofcrc32.o
a - ofdate.o
a - oftime.o
a - ofdatime.o
a - ofconfig.o
ranlib libofstd.a
make[3]: quittant le répertoire « /home/didrocks/sandbox/dcmtk-3.5.4/ofstd/libsrc »
(cd tests; /usr/bin/make ARCH="" all)
make[3]: entrant dans le répertoire « /home/didrocks/sandbox/dcmtk-3.5.4/ofstd/tests »
c++ -DHAVE_CONFIG_H -DNDEBUG -c -I. -I. -I../include -I../../config/include -I../include \
   -O -I/usr/include/libxml2 -D_REENTRANT -D_XOPEN_SOURCE_EXTENDED -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_BSD_COMPAT -D_OSF_SOURCE -D_POSIX_C_SOURCE=199506L -g -O2 tststack.cc
c++ -O -I/usr/include/libxml2 -D_REENTRANT -D_XOPEN_SOURCE_EXTENDED -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_BSD_COMPAT -D_OSF_SOURCE -D_POSIX_C_SOURCE=199506L -g -O2 -Wl,-Bsymbolic-functions -L../libsrc -o tststack tststack.o -lofstd -lrt -lpthread -lnsl
../libsrc/libofstd.so: undefined reference to `sem_init'
../libsrc/libofstd.so: undefined reference to `pthread_mutex_trylock'
../libsrc/libofstd.so: undefined reference to `pthread_rwlock_trywrlock'
../libsrc/libofstd.so: undefined reference to `pthread_key_create'
../libsrc/libofstd.so: undefined reference to `pthread_rwlock_rdlock'
../libsrc/libofstd.so: undefined reference to `pthread_rwlock_tryrdlock'
../libsrc/libofstd.so: undefined reference to `sem_destroy'
../libsrc/libofstd.so: undefined reference to `pthread_getspecific'
../libsrc/libofstd.so: undefined reference to `pthread_rwlock_wrlock'
../libsrc/libofstd.so: undefined reference to `pthread_create'
../libsrc/libofstd.so: undefined reference to `pthread_rwlock_destroy'
../libsrc/libofstd.so: undefined reference to `pthread_rwlock_init'
../libsrc/libofstd.so: undefined reference to `pthread_rwlock_unlock'
../libsrc/libofstd.so: undefined reference to `sem_post'
../libsrc/libofstd.so: undefined reference to `sem_trywait'
../libsrc/libofstd.so: undefined reference to `pthread_setspecific'
../libsrc/libofstd.so: undefined reference to `sem_wait'
../libsrc/libofstd.so: undefined reference to `pthread_join'
collect2: ld returned 1 exit status
make[3]: *** [tststack] Erreur 1
make[3]: quittant le répertoire « /home/didrocks/sandbox/dcmtk-3.5.4/ofstd/tests »

I think that should be related to the new DSO linking policy (http://wiki.debian.org/ToolChain/DSOLinking). Can you please have a look at it?

It would be nice if someone in the team subscribe to the bug report (and it seems to be a very _low_ traffic).
Keeping in sync with debian sounds the best option fixing those issues.

(note: 3.6.0 is just out for a few days, if someone wants to take care of that and package in experimental, it seems to have an impressive list of new features and seems to fix the -fPIC issue forcing to make some trick in debian/rules).

As well, I'm subscribing kees, as this package is making some network traffic and doing a lot of system() call, it will be nice to have a review there.