Comment 70 for bug 893091

On Dec 12, 2011, at 12:41 PM, <email address hidden> wrote:

>So the main thing I'm not happy about here is the handling of UTF8String.
>
>I've already explained what the rationale for UTF8String was, and it makes no
>sense in a Python 3 world, so I think we can categorise it as "failed
>experiment" and move on. Here is my suggestion:

Yep. I was careful (but maybe screwed up) to remove UTF8String from the
Python 3 port. It still exists for backward compatibility in Python 2.

>* Don't make keywords() public or expect library users to call it

Done.

>* Don't use UTF8String in library code except where needed to implement
> existing semantics; don't use it in tests except where the purpose of
> the test is to demonstrate that UTF8String works
>
>* Skip tests whose only purpose is to demonstrate UTF8String in Python 3,
> since they're meaningless

All the places where UTF8String occurs in the tests are protected by the `if
not _is_py3` test, meaning those tests only run in Python 2. Note that I have
not updated the docstrings to reflect this, but I have a big TODO to fix up
the docstrings.

Similarly I think UTF8String only barely shows up at the Python level anyway,
and its import or exposure in __all__ is always conditionalized on the Python
version.

Was there something more you want me to do?