Ubuntu
dbus-python package

  1. Bug #356281
  2. Comment #20

Comment 20 for bug 356281

Revision history for this message
In , David-laban (david-laban) wrote :

(In reply to comment #2)
> I don't think that's the right patch for this, but I've prepared another:
>
> http://git.collabora.co.uk/?p=user/smcv/dbus-python-smcv.git;a=shortlog;h=refs/heads/2.6
>

I'm probably not the best person to be reviewing this, but...

The "Passing arbitrary args into an __init__ and getting them silently ignored" thing deprecated in 2.6 for a reason. If we at least warn about args/kwargs we don't understand then ++. I don't know the codebase enough to be able to quickly assert whether we do or not. If someone more knowledgeable than me can assert this then ship it.

If we don't warn about unknown args, then on a scale of "completely fine" to "as messed up as overriding __getattr__" I would give this a 5.