Comment 3 for bug 696658

Revision history for this message
Scott Moser (smoser) wrote :

Isreal,
  Thank you for taking the time to report a bug and develop a patch. We would like to get the fix in to Ubuntu, but the best case scenario is for us to get the bug fixed in upstream, so we do not have maintain a delta. In my understanding, your fix seems straight forward and I would expect it to be accepted upstream.

  Could you open a bug against the upstream project and attach your patch there ? Upstream bug tracking appears to be at https://bugzilla.gnome.org/browse.cgi?product=dates (as linked from the project homepage at http://www.pimlico-project.org/dates.html ). It would be great to get the upstream developers ACK.

  The only issues I saw with your patch were minor whitespace changes.
  * your dates_today_cb uses indentaion of 3 spaces instead of 4.
  * dates_view_get_zone uses 8 spaces rather than tab
  White space issues are probably not deal-breakers, but there is no reason to make the files less consistently indented then they were.

  Once you've done that, the easiest way for an Ubuntu developer to pull your change in is if you create a branch (as you did) and propose that for merging into lp:ubuntu/dates . Note, you'll want to edit the debian/changelog appropriately.