Comment 4 for bug 19836

Message-Id: <email address hidden>
Date: Mon, 20 Jun 2005 08:26:52 -0700
From: Matt Kraai <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: FTBFS: broken postgresql header include

--===============1948986171==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: cyrus-sasl2
Severity: serious
Justification: no longer builds from source

cyrus-sasl2 fails to include libpq-fe.h, which causes it to fail to
build:

 if /bin/sh ../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -I../lib -I../sasldb -I../include -I/usr/include/mysql -I/usr/include -Wall -W -fno-strict-aliasing -g -O2 -MT sql.lo -MD -MP -MF ".deps/sql.Tpo" \
   -c -o sql.lo `test -f 'sql.c' || echo './'`sql.c; \
 then mv -f ".deps/sql.Tpo" ".deps/sql.Plo"; \
 else rm -f ".deps/sql.Tpo"; exit 1; \
 fi
  gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -I../lib -I../sasldb -I../include -I/usr/include/mysql -I/usr/include -Wall -W -fno-strict-aliasing -g -O2 -MT sql.lo -MD -MP -MF .deps/sql.Tpo -c sql.c -fPIC -DPIC -o .libs/sql.o
 sql.c:183:33: postgresql/libpq-fe.h: No such file or directory
 sql.c: In function `_pgsql_open':
 sql.c:189: error: `PGconn' undeclared (first use in this function)
 sql.c:189: error: (Each undeclared identifier is reported only once
 sql.c:189: error: for each function it appears in.)
 sql.c:189: error: `conn' undeclared (first use in this function)
 sql.c:247: warning: implicit declaration of function `PQconnectdb'
 sql.c:250: warning: implicit declaration of function `PQstatus'
 sql.c:250: error: `CONNECTION_OK' undeclared (first use in this function)
 sql.c:251: warning: implicit declaration of function `PQerrorMessage'
 sql.c: In function `_pgsql_escape_str':
 sql.c:260: warning: implicit declaration of function `PQescapeString'
 sql.c: In function `_pgsql_exec':
 sql.c:266: error: `PGresult' undeclared (first use in this function)
 sql.c:266: error: `result' undeclared (first use in this function)
 sql.c:268: error: `ExecStatusType' undeclared (first use in this function)
 sql.c:268: error: syntax error before "status"
 sql.c:271: warning: implicit declaration of function `PQexec'
 sql.c:274: error: `status' undeclared (first use in this function)
 sql.c:274: warning: implicit declaration of function `PQresultStatus'
 sql.c:275: error: `PGRES_COMMAND_OK' undeclared (first use in this function)
 sql.c:277: warning: implicit declaration of function `PQclear'
 sql.c:280: error: `PGRES_TUPLES_OK' undeclared (first use in this function)
 sql.c:283: warning: implicit declaration of function `PQresStatus'
 sql.c:289: warning: implicit declaration of function `PQntuples'
 sql.c:304: warning: implicit declaration of function `PQgetvalue'
 sql.c:304: warning: passing arg 1 of `strlen' makes pointer from integer without a cast
 sql.c:304: warning: passing arg 2 of `memcpy' makes pointer from integer without a cast
 sql.c:304: warning: passing arg 2 of `strncpy' makes pointer from integer without a cast
 sql.c:304: warning: passing arg 2 of `strncpy' makes pointer from integer without a cast
 sql.c: In function `_pgsql_close':
 sql.c:331: warning: implicit declaration of function `PQfinish'
 make[3]: *** [sql.lo] Error 1
 make[3]: Leaving directory `/tmp/buildd/cyrus-sasl2-2.1.19/build-tree/cyrus-sasl-2.1.19/plugins'
 make[2]: *** [all-recursive] Error 1
 make[2]: Leaving directory `/tmp/buildd/cyrus-sasl2-2.1.19/build-tree/cyrus-sasl-2.1.19'
 make[1]: *** [all] Error 2
 make[1]: Leaving directory `/tmp/buildd/cyrus-sasl2-2.1.19/build-tree/cyrus-sasl-2.1.19'
 make: *** [stampdir/build-stamp] Error 2

Replacing debian/patches/09_postgres_header.diff with the attached
file fixes this problem.

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: powerpc (ppc)
Kernel: Linux 2.6.8-powerpc
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

--===============1948986171==
Content-Type: text/x-c; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="09_postgres_header.diff"

diff -ruN cyrus-sasl-2.1.19-old/plugins/sql.c cyrus-sasl-2.1.19/plugins/sql.c
--- cyrus-sasl-2.1.19-old/plugins/sql.c 2004-06-30 12:31:11.000000000 -0700
+++ cyrus-sasl-2.1.19/plugins/sql.c 2005-06-20 07:05:00.000000000 -0700
@@ -180,7 +180,7 @@
 #endif /* HAVE_MYSQL */

 #ifdef HAVE_PGSQL
-#include <libpq-fe.h>
+#include <postgresql/8.0/libpq-fe.h>

 static void *_pgsql_open(char *host, char *port, int usessl,
     const char *user, const char *password,

--===============1948986171==--