curthooks running apt-config unconditionnally
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
subiquity |
Fix Released
|
Undecided
|
Olivier Gayot | ||
curtin (Ubuntu) |
Fix Committed
|
Undecided
|
Olivier Gayot |
Bug Description
The conditional execution of apt_config.
A regression was introduced in 2016 when adding a mechanism to translate things like:
```
debconf_
foobar foobar
```
The function responsible for calling handle_apt is as follows:
def do_apt_config(cfg, target):
cfg = apt_config.
apt_cfg = cfg.get("apt")
if apt_cfg is not None:
else:
Sadly, the implementation of translate_
This bug is the root cause:
https:/
https:/
I suggest we revert the changes after merging the relevant fixes
Related branches
- Michael Hudson-Doyle: Approve
- Dan Bungert: Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 173 lines (+86/-9)4 files modifiedcurtin/commands/apt_config.py (+8/-8)
curtin/commands/curthooks.py (+1/-1)
tests/unittests/test_apt_source.py (+44/-0)
tests/unittests/test_curthooks.py (+33/-0)
Changed in curtin (Ubuntu): | |
assignee: | nobody → Olivier Gayot (ogayot) |
status: | New → In Progress |
Changed in subiquity: | |
assignee: | nobody → Olivier Gayot (ogayot) |
status: | New → In Progress |
description: | updated |
tags: | added: fr-3533 |
summary: |
- curthooks runnng apt-config unconditionnally + curthooks running apt-config unconditionnally |
Changed in subiquity: | |
status: | In Progress → Fix Committed |
Changed in curtin (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in subiquity: | |
status: | Fix Committed → Fix Released |