Comment 8 for bug 2052925

I noticed this SRU was prepared without the SRU Template[1] filled in. While most of the data we want is in the bug description as is (what's wrong, test plan), it's lacking an analysis of what could go wrong.

That boat has sailed now, and doing an analysis of the patch right now, basically what could go wrong is if someone was relying on the old behavior, of the command only changing the local user's (root in this case) config, instead of system-wide.

The lpoptions[1] manpage doesn't really special case root when the -d option is used:

       -d destination[/instance]
            Sets the user default printer to destination. If instance is supplied then that
            particular instance is used. This option overrides the system default printer for
            the current user.

But later down, in "FILES", we see:

       ~/.cups/lpoptions - user defaults and instances created by non-root users.
       /etc/cups/lpoptions - system-wide defaults and instances created by the root user.

So it does seem the intention of that option when used by the root user was to update the system-wide /etc/cups/lpoptions file instead.

So even if someone was relying on the previous behavior, it was incorrect, and the documentation (which could be clearer, but isn't) seems to agree that the previous behavior was incorrect.

That's the kind of analysis we would like to see in "what could go wrong", and "other info" sections of the SRU template.

1. https://manpages.ubuntu.com/manpages/jammy/en/man1/lpoptions.1.html