I just discovered one minor bug in my patch: the returncode-check is somewhat useless now as it would check only the rc of the last usplash_write command in case we have usplash running.
Here is an updated patch. (This patch is against the 1.0.4-8ubuntu1 package from feisty that I backported to edgy...)
I tested it on edgy with usplash enabled and usplash disabled, with correct passphrase and three times wrong passphrase entered.
What looks a bit odd: entering the wrong passphrase three times with usplash prints out many asterisks... and while entering the passphrase there are no asterisks shown.. so I guess this is an issue with usplash itself.
For John Doe user it might be good if he sees those while typing the passphrase. Somewhat cosmetic, but for the records.
I just discovered one minor bug in my patch: the returncode-check is somewhat useless now as it would check only the rc of the last usplash_write command in case we have usplash running.
Here is an updated patch. (This patch is against the 1.0.4-8ubuntu1 package from feisty that I backported to edgy...)
I tested it on edgy with usplash enabled and usplash disabled, with correct passphrase and three times wrong passphrase entered.
What looks a bit odd: entering the wrong passphrase three times with usplash prints out many asterisks... and while entering the passphrase there are no asterisks shown.. so I guess this is an issue with usplash itself.
For John Doe user it might be good if he sees those while typing the passphrase. Somewhat cosmetic, but for the records.
-Marc