Comment 95 for bug 1063617

Revision history for this message
Lukas Vacek (lukas-vacek) wrote :

Thanks.

I tried on my other up to date Trusty box last night and I can't reproduce the issue anymore (with the patch in), so a bit more info:

The issues found:

1) updateSetting (in gsettings/src/gsettings.c) always uses readOption (even when integration is turned on). This function should use readIntegratedOption when integration is turned on (as readSetting does).

2) ccsGSettingsIntegratedSettingWriteValue (in ccs_gnome_integration_gsettings_integrated_setting.c) function is called when writing a new value to gsettings backend. In this function, newVariant is set only when the old a new values differ but at the end of the function, the key is reset when newVariant is NULL.

Testing:

The two packages you want to update are (at least) libcompizconfig0 and compiz-gnome.

If you want to test the patch, please make sure to restart compiz (and ccsm if currently running) after installing the new packages. Maybe better just to reboot the box after install when testing (just to be sure the new libraries are used). If your settings are reset at this stage, set the settings as you like and start testing now :-).

Also note that if you are using the "Flat file workaround" or Gsettings backend with "desktop integration" disabled this patch should not affect you. So to verify the patch actually fixes the issue, you should export your settings, switch to gsettings backend and turn on desktop integration and import your settings.