CCSGNOMEMediaKeys/CCSGNOMEIntegrationTestWriteIntegratedMediaKeys.TestWriteIntegratedMediaKey/* fail in jenkins
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Compiz |
Fix Released
|
High
|
Sam Spilsbury | ||
0.9.8 |
Fix Released
|
High
|
Sam Spilsbury | ||
0.9.9 |
Fix Released
|
High
|
Sam Spilsbury | ||
compiz (Ubuntu) |
Fix Released
|
High
|
Sam Spilsbury |
Bug Description
These tests fail in pbuilder environments:
[ RUN ] CCSGNOMEMediaKe
unknown file: Failure
Unexpected mock function call - returning directly.
Function call: writeValue(
Google Mock tried the following 1 expectation, but it didn't match:
/tmp/buildd/
Expected arg #0: points to a value that Value Matches <Control><Alt>Print
Actual: 0x1e5bcb0, which points to Possible values in CCSSetting :
31833344
31833344
8.43925e-38
<Control>
Red: bd00Blue: 0Green: 1e5Alpha: 0
An action value
Keysym: 31833344 KeyModMask 0
Button 31833344Button Key Mask: 0Edge Mask: 0
31833344
31833344
<Control>
A list value
(of type _CCSSettingValue)
Expected: to be called once
Actual: never called - unsatisfied and active
/tmp/buildd/
Actual function call count doesn't match EXPECT_CALL(Mock (*mIntegratedSe
Expected: to be called once
Actual: never called - unsatisfied and active
[ FAILED ] CCSGNOMEMediaKe
[ RUN ] CCSGNOMEMediaKe
unknown file: Failure
Unexpected mock function call - returning directly.
Function call: writeValue(
Google Mock tried the following 1 expectation, but it didn't match:
/tmp/buildd/
Expected arg #0: points to a value that Value Matches <Control><Alt>t
Actual: 0x1e5ad70, which points to Possible values in CCSSetting :
31840912
31840912
8.44349e-38
<Control>
Red: da90Blue: 0Green: 1e5Alpha: 0
An action value
Keysym: 31840912 KeyModMask 0
Button 31840912Button Key Mask: 0Edge Mask: 0
31840912
31840912
<Control>
A list value
(of type _CCSSettingValue)
Expected: to be called once
Actual: never called - unsatisfied and active
/tmp/buildd/
Actual function call count doesn't match EXPECT_CALL(Mock (*mIntegratedSe
Expected: to be called once
Actual: never called - unsatisfied and active
[ FAILED ] CCSGNOMEMediaKe
The problem appears to be that we add <Primary> to keybinding strings indiscriminately. We should only be converting from <Primary> to ControlMask and not the other way around. This patch should also really be upstreamed
Related branches
- Daniel van Vugt: Approve
- jenkins (community): Needs Fixing (continuous-integration)
- Sam Spilsbury: Approve
-
Diff: 500 lines (+371/-26)5 files modifiedcompizconfig/libcompizconfig/src/bindings.c (+52/-26)
compizconfig/libcompizconfig/src/ccs-modifier-list-inl.h (+50/-0)
compizconfig/libcompizconfig/src/ccs-private.h (+19/-0)
compizconfig/libcompizconfig/tests/CMakeLists.txt (+12/-0)
compizconfig/libcompizconfig/tests/compizconfig_test_ccs_util.cpp (+238/-0)
- Daniel van Vugt: Approve
-
Diff: 12 lines (+1/-1)1 file modifiedcompizconfig/integration/gnome/tests/compizconfig_test_ccs_gnome_integration.cpp (+1/-1)
- Compiz Maintainers: Pending requested
-
Diff: 22 lines (+5/-1) (has conflicts)2 files modifiedVERSION (+4/-0)
compizconfig/integration/gnome/tests/compizconfig_test_ccs_gnome_integration.cpp (+1/-1)
Changed in compiz: | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Sam Spilsbury (smspillaz) |
milestone: | none → 0.9.9.0 |
Changed in compiz: | |
status: | In Progress → Fix Committed |
no longer affects: | compiz (Ubuntu) |
Changed in compiz (Ubuntu): | |
assignee: | nobody → Sam Spilsbury (smspillaz) |
importance: | Undecided → High |
status: | New → Fix Committed |
Fix committed into lp:compiz/0.9.8 at revision 3406