Comment 1 for bug 1990623
Revision history for this message
| Martin Pitt (pitti) wrote Re: Login page fails with “This web browser is too old” error with upcoming browsers | #1 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
The fix for this unfortunately looks a little wild. The actual source change in pkg/static/login.js is very small and obvious, that's not what the browser actually consumes. That's the so-called "webpacks" in dist/, which are compiled/bundled and minified JavaScript files.
The Debian package does *not* run webpack during build, as that either needs internet access, or shipping hundreds of NPM modules. So upstream releases contain the pre-built webpacks in dist/. For the fix to be effective, the resulting webpack must be patched as well. That is done in the diff, but as the webpack is essentially just a single huge line, it's very large.
This is the first-ever bug that we patch in a stable release in this minimal fashion. We have very strong integration tests for all distros, so we don't usually have major issues/regressions -- so we haven't developed a more streamlined approach to SRU patches, sorry!