Ubuntu
cobbler-enlist package

  1. Bug #860492
  2. Comment #4

Comment 4 for bug 860492

Revision history for this message
Jamie Strandboge (jdstrand) wrote : Re: [MIR] cobbler-enlist src, cobbler-enlist-udeb bin

I'm not done with my review yet, but I wanted to mention the following:

cobbler-xmlrpc.h
- PROBLEM: most xmlrpc_* calls are not doing any error checking, but should be based on looking at code of xmlrpc-c.
- RECOMMENDATION: create utility function wrappers for the common xmlrpc-c comamnds, have the cobbler-enlist code use the wrappers, and have the wrappers do all the error checking. Eg: all current uses of xmlrpc_array_new(...) should be changed to use ce_xmlrpc_array_new(...), then ce_xmlrpc_array_new() calls xmlrpc_array_new() and does the necessary error checking and fails. This should be done everywhere that an xmlrpc function is used a lot, and for those things that are used only once, simply do it inline (eg for xmlrpc_server_info_new()).