Comment 4 for bug 1836929

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

This happens because output of clknetsim was modified and the following regex:

  # Check if only NTP port (123) was used
  check_packet_port() {
      local i ret=0 port=123

      test_message 2 1 "checking port numbers in packet log:"

+ set -x
+
+ cp tmp/log.packets /tmp/mine.log.packets
+
      for i in $(seq 1 $(get_chronyd_nodes)); do
          test_message 3 0 "node $i:"

          grep -E -q " $port [0-9]+\$" tmp/log.packets && \
              ! grep -E "^[0-9e.+-]+ $i " tmp/log.packets | \
              grep -E -q -v " $port [0-9]+\$" && \
              test_ok || test_bad
          [ $? -eq 0 ] || ret=1
      done

+ set +x
+
      return $ret
  }

Broke. Example of the output change:

# good (old) output (vi :set list)

2.020970e-01>---1>--2>--1.854754e-04>---123>123>1$
2.022825e-01>---2>--1>--2.935628e-04>---123>123>1$
2.027594e-01>---2>--1>--1.794174e-04>---123>123>1$
2.029388e-01>---1>--2>--2.045724e-04>---123>123>1$

# bad (new) output (vi :set list)

2.066646e+03>---2>--1>--1.297676e-04>---123>123>1>--48>-1$
2.066646e+03>---1>--2>--1.520290e-04>---123>123>1>--48>-1$
2.191654e+03>---1>--2>--1.690480e-04>---123>123>1>--48>-1$
2.191654e+03>---2>--1>--4.082407e-04>---123>123>1>--48>-1$

TODO:

- make a change to eoan so clknetsim code is compatible (so this wont happen again)
- mark this test as faulty for previous chronie versions (since they will always fail)
- (could do) fix autopkgtest next time chronie needs a SRU (disco/bionic)