Please stop build-depending on libgnome-keyring

[Julian Andres Klode]

libgnome-keyring is not maintained anymore, but chromium build-depends on it. It should be using libsecret instead. The generated binaries depend on neither library, which is a bit confusing.

[Julian Andres Klode (juliank)]

FWIW, it seems libsecret is shipped as a vendorized library, as the build log says:

[7656/36567] AR obj/third_party/libsecret/libsecret.a

Might be useful to use the system-wide libsecret instead.

[Julian Andres Klode (juliank)]

As a side note, Debian also builds with use_gnome_keyring = false, so it's perfectly safe to do so.

[Olivier Tilloy (osomon)]

chromium doesn't expose a build flag to use the system-wide libsecret, it always relies on the vendorized library.

[Launchpad Janitor (janitor)]

This bug was fixed in the package chromium-browser - 74.0.3729.131-0ubuntu2

---------------
chromium-browser (74.0.3729.131-0ubuntu2) eoan; urgency=medium

  * debian/control: remove libgnome-keyring-dev build dependency (LP: #1828192)
  * debian/rules: build with use_gnome_keyring=false
  * debian/known_gn_gen_args-*: change use_gnome_keyring build flag to false

 -- Olivier Tilloy <email address hidden> Wed, 08 May 2019 12:15:30 +0200

[Olivier Tilloy (osomon)]

https://bazaar.launchpad.net/~chromium-team/chromium-browser/xenial-stable/revision/1440

https://bazaar.launchpad.net/~chromium-team/chromium-browser/bionic-stable/revision/1512

https://bazaar.launchpad.net/~chromium-team/chromium-browser/disco-stable/revision/1544

[Launchpad Janitor (janitor)]

This bug was fixed in the package chromium-browser - 79.0.3945.130-0ubuntu0.18.04.1

---------------
chromium-browser (79.0.3945.130-0ubuntu0.18.04.1) bionic; urgency=medium

  * Upstream release: 79.0.3945.130
    - CVE-2020-6378: Use-after-free in speech recognizer.
    - CVE-2020-6379: Use-after-free in speech recognizer.
    - CVE-2020-6380: Extension message verification error.
  * debian/control: remove libgnome-keyring-dev build dependency (LP: #1828192)
  * debian/rules: build with use_gnome_keyring=false
  * debian/known_gn_gen_args-*: change use_gnome_keyring build flag to false

 -- Olivier Tilloy <email address hidden> Mon, 27 Jan 2020 17:57:12 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package chromium-browser - 79.0.3945.130-0ubuntu0.16.04.1

---------------
chromium-browser (79.0.3945.130-0ubuntu0.16.04.1) xenial; urgency=medium

  * Upstream release: 79.0.3945.130
    - CVE-2020-6378: Use-after-free in speech recognizer.
    - CVE-2020-6379: Use-after-free in speech recognizer.
    - CVE-2020-6380: Extension message verification error.
  * debian/control: remove libgnome-keyring-dev build dependency (LP: #1828192)
  * debian/rules: build with use_gnome_keyring=false
  * debian/known_gn_gen_args-*: change use_gnome_keyring build flag to false

 -- Olivier Tilloy <email address hidden> Mon, 27 Jan 2020 17:44:47 +0100