Comment 7 for bug 751701

Hi,

I took a system with checkbox 0.13.7, and ran the command given in the test section, I get this:
Traceback (most recent call last):
  File "/usr/share/checkbox/scripts/network_check", line 64, in <module>
    sys.exit(main())
  File "/usr/share/checkbox/scripts/network_check", line 40, in main
    results[protocol] = check_url(value)
  File "/usr/share/checkbox/scripts/network_check", line 17, in check_url
    urllib2.urlopen(url)
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1146, in do_open
    h = http_class(host, timeout=req.timeout) # will parse host:port
  File "/usr/lib/python2.7/httplib.py", line 693, in __init__
    self._set_hostport(host, port)
  File "/usr/lib/python2.7/httplib.py", line 721, in _set_hostport
    raise InvalidURL("nonnumeric port: '%s'" % host[i+1:])
httplib.InvalidURL: nonnumeric port: ' text'

Then I installed checkbox 0.13.8 from -proposed, ran the same command. I get nothing on the command line, and a small window pops up indicating the http connection failed (understandably, since the proxy is purposefully invalid). This is the correct behavior as indicated by the test case.

Just for kicks, I then set a valid proxy and ran with both checkbox 0.13.7 and checkbox 0.13.8. In both cases it said the connection failed, but that's because the URL they are trying to load no longer exists (see https://launchpad.net/bugs/1065855). This issue is orthogonal to the current bug; I manually modified the network_check script to point to a valid URL, and then it works fine (says HTTP Connection: Success). So the proposed fix is working as expected.

I'll mark verification-done based on the above.