Comment 6 for bug 725645

Revision history for this message
Artur Rona (ari-tczew) wrote :

Thank you for your time and efforts making Ubuntu better! However, I have some concerns:

1) This package does not exist in Debian anymore. We should check whether it should be removed from Ubuntu as well.

2) I am not sure whether upgrading QA stuff is in our interesting in Feature Freeze. If so, please improve it, so:
- d/control: Please use debhelper (>= 8)
 -d/compat: 8
- d/rules: Convert it to tiny small mode

3) Changes applied directly to Makefile and chaplin.c are not documented in d/changelog and do not needed to build, so I would like to see them dropped.

4) You did not document upgrade debhelper in d/changelog.

5) You call LIBS in Makefile which is wrong. After cleaning up Makefile please just move -ldvdread at the end of line 9.

To avoid wasting time, first make sure about 1) point.