Comment 0 for bug 1835354

Revision history for this message
James Page (james-page) wrote :

On startup the ceph-mgr daemon fails to load the crash module due to invalid Python 3 syntax:

2019-07-04 04:11:54.533 7f1af75ab300 1 mgr[py] Loading python module 'crash'
2019-07-04 04:11:54.605 7f1af75ab300 -1 mgr[py] Module not found: 'crash'
2019-07-04 04:11:54.605 7f1af75ab300 -1 mgr[py] Traceback (most recent call last):

  File "/usr/lib/x86_64-linux-gnu/ceph/mgr/crash/__init__.py", line 1, in <module>
    from .module import Module
  File "/usr/lib/x86_64-linux-gnu/ceph/mgr/crash/module.py", line 48
    def inner((_, meta)):
              ^
SyntaxError: invalid syntax

Looking at the history for this module there are a number of syntax/compat fixes for Python3:

https://github.com/ceph/ceph/commit/9aa1d49583ae8fb658967c054247cac6ec2125ab#diff-9433ab33e8bbf1048734205a3a1141ed
https://github.com/ceph/ceph/commit/bcf0f4df2db8b51c58e5ca4d411d05e2a4d081ab#diff-9433ab33e8bbf1048734205a3a1141ed
https://github.com/ceph/ceph/commit/6dc95544512362c202535139c323717ec867e20b#diff-9433ab33e8bbf1048734205a3a1141ed