Comment 3 for bug 1969775

Revision history for this message
James Page (james-page) wrote :

@chris.macnaughton

looked at your proposed patch and have questions.

Do we not need more of:

   https://github.com/ceph/ceph-iscsi/commit/4d04457ddaa9103cafccdad239b0dc5f1cbd0530

as there seems to be changes in both the cli interface as well as the return values of the command?

That commit is not a clean cherry-pick to 3.4 but its not far off.

If that's not all needed could you please annotate your patch with headers so we have documentation around the approach and that a different fix can be found in later releases of Ceph.

Thanks!