Comment 1 for bug 653633

Revision history for this message
tarski (guy-laffitte) wrote :

  I have a couple of remarks to formulate about this bug.

1. I have been unable to find where variable LIVEMEDIA_TIMEOUT is set. If is is never set, it is useless. There are thus two solutions : either remove it, or add boot parameter ( for example "live-media-timeout=xx" ) to set it.

2. A user who specifies "live_media" boot parameter ( generally ) does not want to boot on another device. The use of this parameter did not work well because the script fell back in normal scan when the attempt with LIVEMEDIA failed. The race condition is generally not in favour of USB devices faced to other ones, due to latency.
   I prefer not to waste time in case of boot failure if there is a mistake in live-media parameter rather than a successful boot on a wrong device. So, I propose to make scan of LIVEMEDIA and normal scan mutually exclusive. In "find_livefs" the code could be something like this ( letting drop LIVEMEDIA_TIMEOUT ) :

  if [ ! -z "${LIVEMEDIA}" ]; then
    # scan with LIVEMEDIA
  else
    # normal scan
  fi