Comment 23 for bug 237690

Revision history for this message
In , Ted Mielczarek (ted-mielczarek) wrote :

(From update of attachment 322801)
>Index: configure.in
>===================================================================
>- if test "$CPU_ARCH" != "ia64" && test "$CPU_ARCH" != "sparc" \
>+ if test "$CPU_ARCH" != "hppa" && test "$CPU_ARCH" != "ia64" && test "$CPU_ARCH" != "sparc" \
> && test -z "$INTEL_CC"; then
>- # don't use -Wcast-align on ia64 or sparc, it's noisy on those platforms
>+ # don't use -Wcast-align on hppa, ia64 or sparc, it's noisy on those platforms
> # icc doesn't support this flag.
> _WARNINGS_CFLAGS="${_WARNINGS_CFLAGS} -Wcast-align"
> fi

This is getting unwieldy, could you refactor this into a case statement? Same thing with the other bit. Other than that, looks ok.