Comment 44 for bug 153625

Revision history for this message
James Westby (james-w) wrote :

Hi,

I've tested the debs in proposed and realised I made a mistake.

When I tested my versions I was installing using dpkg, when
switching to apt for testing -proposed the questions were
being asked too many times.

I had forgotten that apt will call the config script multiple times
when upgrading, and so the forcing of the question to unseen
for some people meant that it was asked multiple times.

Colin suggsted that I could work around this by adding another
attribute when the question is forced using db_fset. This seems
to work well, and would provide a way to limit the number of
times the question is asked without resorting to the version
comparisons that early versions of my patch had.

The proposed situation would look like:

  * Use the same logic as before to detect whether
     the user appears to be affected, if they are then ask the
     question and use db_fset to record the fact that we
     did this. Then check for this new attribute as well
     to make sure it is only forced once.
  * Only clean up the attribute in the postinst of the version
     in Hardy, so that it will mean the question is only
     asked once, rather than once per release upgrade, as the
     current version has it.

The remaining open question is how to handle those that
have already tested the .debs in -proposed. They may have
been asked the question more than once, and there is
nothing we can do about that. However, currently they would
not have the new attribute set, and so would be asked again
next time they upgraded their distribution.

One solution would be to set the flag unconditionally if they
are upgrading from the version in -proposed. That should be
ok, as they will have had the problem fixed up, and we don't
need to ask them again.

I will post some more patches for this solution later.

Apologies for not catching this earlier.

Thanks,

James