Comment 32 for bug 153625

Hi,

Attached is my improved fix for hardy, it does the following things

  * If the user has an empty file and the template has not been seen
     it probably means that they installed under pt_BR and were hit by
     this issue and they have not run dpkg-reconfigure ca-certificates.
     It will then just behave like a new install.

  * If the has an empty file an the template has been seen it means
     one of two things
     - Either they were hit by the issue and ran dpkg-reconfigure
       ca-certificates.
     - Or they were not hit by the issue and have deselected all
       certificates.

     = To help the first case if $LC_ALL=pt_BR.UTF-8 then we show
        the question with critical priority and preselect everything,
        so that they can select, but it's easy to get the behaviour
        of a fresh install.

     = If they are not currently under pt_BR.UTF-8 then we leave it
        as is. The only users who will suffer from this are those that
        were hit by the issue, ran dpkg-reconfigure, and have since
        changed locales.

  * Otherwise it just does nothing.

I have tested the following scenarios

   * install in pt_BR and then upgrade - like default install
   * install in pt_BR, dpkg-reconfigure and upgrade - question with all certs selected by default
   * install in pt_BR, switch to en_GB, upgrade - like default install
   * install in pt_BR, dpkg-reconfigure, switch to en_GB, upgrade - still empty file
      - dpkg-reconfigure shows the question with no certs highlighted by default.
   * install new version in pt_BR - like default install

   * install in en_GB, upgrade - like default install
   * install new version in en_GB - like default install
   * install in en_GB, dpkg-reconfigure and deselect all, upgrade - empty file
   * install in en_GB, dpkg-reconfigure and deselect all,
        switch to pt_BR, upgrade - shown the question and have to deselect all again.

I think this is good, as the only users it really annoys are those that
changed locales. Those who changed to en_GB have an empty file,
but dpkg-reconfigure will still work for them. Those that changed
to pt_BR have an extra question, but at least they don't get
certificates they don't want activated without their consent.

My only remaining worry is preseeding, does that set the seen
attribute of the questions that are preseeded? Otherwise
there may be unexpected behaviour their.

Also using a lt-ne version check only means that the last case will
be asked the question multiple times, once when they go
to the fixed version, and once for each dist-upgrade until hardy,
so if they are on edgy that could be as many as 4 times.

Thanks,

James