Comment 1 for bug 322327

Revision history for this message
Thierry Carrez (ttx) wrote :

I think we need to hook in two places:

- InterTree.iter_changes (tree.py:928)
We need to yield file_ids that happen to just have a permissions/ownership change. A hook allowing to arbitrarily yield some entries (given their file_id) would definitely help.

- DiffTree._show_diff (diff.py:867)
We need to add permissions/ownership changes to properties_changed. A hook allowing to do that would be great. The alternative is to use the existing diff_factory system register a DiffPath that would represent the permissions/ownership change as a "content change". Less intrusive but somehow inexact.

Those shouldn't require any API change. I'll try to do a PoC for them.