bzr-fastimport crashes on deprecated and removed get_ancestry() method
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Bazaar Fast Import |
High
|
Unassigned | ||
| bzr-fastimport (Ubuntu) |
High
|
Andrew Starr-Bochicchio |
Bug Description
22:31:14 Updating branch information ...
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/usr/lib/
return the_callable(*args, **kwargs)
File "/usr/lib/
ret = run(*run_argv)
File "/usr/lib/
return self.run(
File "/usr/lib/
return self._operation
File "/usr/lib/
self.cleanups, self.func, *args, **kwargs)
File "/usr/lib/
result = func(*args, **kwargs)
File "/usr/lib/
user_
File "/usr/lib/
return proc.process(
File "/usr/lib/
super(
File "/usr/lib/
self.
File "/usr/lib/
branches_
File "/usr/lib/
if self._update_
File "/usr/lib/
ancestry = self.repo.
AttributeError: 'CHKInventoryRe
bzr 2.6b2 on python 2.7.3 (Linux-
Ubuntu-
arguments: ['/usr/bin/bzr', 'fast-import', '-', '/ramdisk/
plugins: bash_completion
fastimport[
news_
encoding: 'utf-8', fsenc: 'UTF-8', lang: 'pl_PL.UTF-8'
*** Bazaar has encountered an internal error. This probably indicates a
bug in Bazaar. You can help us fix it by filing a bug report at
https:/
including this traceback and a description of the problem.
ProblemType: Bug
DistroRelease: Ubuntu 12.10
Package: bzr-fastimport 0.13.0-2
ProcVersionSign
Uname: Linux 3.5.0-18-generic i686
ApportVersion: 2.6.1-0ubuntu6
Architecture: i386
Date: Thu Nov 29 22:54:10 2012
InstallationDate: Installed on 2012-09-07 (83 days ago)
InstallationMedia: Ubuntu 12.10 "Quantal Quetzal" - Alpha i386 (20120905.2)
MarkForUpload: True
PackageArchitec
ProcEnviron:
TERM=xterm-
PATH=(custom, no user)
LANG=pl_PL.UTF-8
SHELL=/bin/bash
SourcePackage: bzr-fastimport
UpgradeStatus: No upgrade log present (probably fresh install)
Zygmunt Krynicki (zyga) wrote : | #1 |
Zygmunt Krynicki (zyga) wrote : | #2 |
The attachment "0.13-2-
[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]
tags: | added: patch |
Changed in bzr-fastimport: | |
status: | New → Confirmed |
Benjamin Drung (bdrung) wrote : | #4 |
Thanks for your work. I like to see your fix accepted by upstream before getting it into the archive. I marked the upstream bzr-fastimport as affected. Please resubscribe ubuntu-sponsors if upstream does not respond (in a timely manner).
The version should be 0.13.0-2ubuntu1 instead of 0.13.0-3 if you want the patch uploaded to Ubuntu. You need supply a patch against the development release (currenly raring) instead of quantal. Please follow [1] if you want the fix in quantal, too. I usually add a .patch suffix to the patch files.
Jelmer Vernooij (jelmer) wrote : | #5 |
Thanks for the patch.
The reason for removing .get_ancestry() was that it scales very badly (with ancestry) and accesses all of the ancestry even when that is not necessary. In this case, I think full ancestry access can be avoided so a more optimal patch is necessary.
Changed in bzr-fastimport (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in bzr-fastimport: | |
importance: | Undecided → High |
Benjamin Drung (bdrung) wrote : | #6 |
Jelmer, is there any progress on this bug? This bug collects duplicates.
Jelmer Vernooij (jelmer) wrote : | #7 |
I'm no longer involved in bzr development. FWIW I think shipping the workaround patch would make sense, as it seems nobody is stepping up to fix this bug properly.
DarkLinkXXXX (darklinkxxxx) wrote : | #8 |
I agree with Jelmer. Applying a patch to get something to work how it's supposed to isn't difficult, but quite annoying.
Jelmer Vernooij (jelmer) wrote : Re: [Bug 1084749] Re: bzr-fastimport crashes on deprecated and removed get_ancestry() method | #9 |
On Sun, Nov 24, 2013 at 07:53:24PM -0000, DarkLinkXXXX wrote:
> I agree with Jelmer. Applying a patch to get something to work how it's
> supposed to isn't difficult, but quite annoying.
I think you misunderstood my reply. The only proposed patch is a
workaround, not a proper fix. It's better than being completely broken
though.
I'll go ahead and make an upload to Debian and sync it into Ubuntu.
Note that bzr-fastimport is orphaned in Debian. If anyone might be interested in taking over its maintenance, I'd be happy to review/sponsor uploads.
Changed in bzr-fastimport (Ubuntu): | |
status: | Triaged → In Progress |
assignee: | nobody → Andrew Starr-Bochicchio (andrewsomething) |
Launchpad Janitor (janitor) wrote : | #11 |
This bug was fixed in the package bzr-fastimport - 0.13.0-3
---------------
bzr-fastimport (0.13.0-3) unstable; urgency=low
* QA upload.
[ Jelmer Vernooij ]
* Add XS-Testsuite: autopkgtest header. Closes: #692658
[ Zygmunt Krynicki ]
* debian/
and removed get_ancestry() method (LP: #1084749).
[ Andrew Starr-Bochicchio ]
* debian/
commit to print sane error when a fastimport file is incomplete
(LP: #937972).
* debian/control: Bump Standards-Version to 3.9.4, no changes needed.
* debian/
- Add python-subunit test dependency.
- Drop undefined "no-build-needed" feature.
-- Andrew Starr-Bochicchio <email address hidden> Sun, 24 Nov 2013 18:01:20 -0500
Changed in bzr-fastimport (Ubuntu): | |
status: | In Progress → Fix Released |
This patch fixes this bug