To address Martin's concerns, I discussed with mpt what the
appropriate user interaction here should be. I did the following:
- I reverted the cancel menu item back to using GTK_STOCK_CANCEL so it
will be translated and then did some additional work to remove the
icon from being displayed.
- Since the application indicator does not give any more information
than the dialog does, I removed the change of the menu item from
cancel -> close. Instead, when the burn is finished, the
application indicator is hidden and the dialog is shown if hidden.
When the dialog is destroyed, the application indicator is also
destroyed.
Hopefully this has both made the interaction simpler and also removed
the string translation issue.
To address Martin's concerns, I discussed with mpt what the
appropriate user interaction here should be. I did the following:
- I reverted the cancel menu item back to using GTK_STOCK_CANCEL so it
will be translated and then did some additional work to remove the
icon from being displayed.
- Since the application indicator does not give any more information
than the dialog does, I removed the change of the menu item from
cancel -> close. Instead, when the burn is finished, the
application indicator is hidden and the dialog is shown if hidden.
When the dialog is destroyed, the application indicator is also
destroyed.
Hopefully this has both made the interaction simpler and also removed
the string translation issue.
Thanks for the feedback Martin.