biosdevname isn't giving interface names as expected

[Kamal Heib]

[Impact]

* Dual port Mellanox HBAs have the second port's name misconfigured

[Test Case]

* "biosdevname -d" on a dual port Mellanox HBA machine

[Regression Potential]

* based on upstream commits/fixes for Mellanox
* already tested by Mellanox and 2 other users

[Other Info]

Original Bug Description:

We see an issue with the biosdevname package that comes with ubuntu 14.04.2 package version 0.4.1-0ubuntu6.1.

There is two issue that we see with Mellanox Card that include two ports:
1- Both ports aren't given interface names with format of "p<num>p<num> (e.g. p514p1) as expected.
2- Second port isn't given "BIOS device" at all.

After update the biosdevname to version 0.6.2 we don't see the issue ( please see below the output of the biosdevname before and after the update).

Could please update the version of the biosdevname package to fix this issue.

Output from "biosdevname -d" for biosdevname 0.4.1-0ubuntu6.1, "BIOS device" and "Kernel name" aren't the same.

BIOS device: p514p1
Kernel name: eth1
Permanent MAC: 00:02:C9:2F:DD:20
Assigned MAC : 00:02:C9:2F:DD:20
ifIndex: 6
Driver: mlx4_en
Driver version: 2.2-1 (Feb 2014)
Firmware version: 2.33.5100
Bus Info: 0000:02:00.0
PCI name : 0000:02:00.0
PCI Slot : 514
SMBIOS Label: RSC-R1UW-2E16 SLOT2 PCI-E X16
Index in slot: 1

BIOS device: <------ no name
Kernel name: eth2
Permanent MAC: 00:02:C9:2F:DD:21
Assigned MAC : 00:02:C9:2F:DD:21
ifIndex: 7
Driver: mlx4_en
Driver version: 2.2-1 (Feb 2014)
Firmware version: 2.33.5100
Bus Info: 0000:02:00.0

Output from "biosdevname -d" for biosdevname 0.6.2, both "BIOS device" and "kernel name" as expected.

BIOS device: p514p1
Kernel name: p514p1
Permanent MAC: 00:02:C9:2F:DD:20
Assigned MAC : 00:02:C9:2F:DD:20
ifIndex: 6
Driver: mlx4_en
Driver version: 2.2-1 (Feb 2014)
Firmware version: 2.33.5100
Bus Info: 0000:02:00.0
PCI name : 0000:02:00.0
PCI Slot : 514
SMBIOS Label: RSC-R1UW-2E16 SLOT2 PCI-E X16
Index in slot: 1

BIOS device: p514p2
Kernel name: p514p2
Permanent MAC: 00:02:C9:2F:DD:21
Assigned MAC : 00:02:C9:2F:DD:21
ifIndex: 7
Driver: mlx4_en
Driver version: 2.2-1 (Feb 2014)
Firmware version: 2.33.5100
Bus Info: 0000:02:00.0
PCI name : 0000:02:00.0
PCI Slot : 514
SMBIOS Label: RSC-R1UW-2E16 SLOT2 PCI-E X16
Index in slot: 1

lsb_release -rd output:
Description: Ubuntu 14.04.2 LTS
Release: 14.04

apt-cache policy biosdevname output:
biosdevname:
  Installed: 0.4.1-0ubuntu6.1
  Candidate: 0.4.1-0ubuntu6.1
  Version table:
 *** 0.4.1-0ubuntu6.1 0
        500 http://webrepo/ubuntu-mirror/ trusty-updates/main amd64 Packages
        100 /var/lib/dpkg/status
     0.4.1-0ubuntu6 0
        500 http://webrepo/ubuntu-mirror/ trusty/main amd64 Packages

[dino99 (9d9)]

Hopes to see that package upgraded, as many changes have been made since that oldish 0.4.1 still used into wily
http://linux.dell.com/files/biosdevname/

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Kamal Heib (kamalh-s)]

Hi Rafael,

Could you please tell if this bug planned to be fixed for trusty (including Ubuntu 14.04.2 and 14.04.3) and vivid versions.

Thanks,
Kamal

[Gideon Naim (gideonn)]

Rafael, we are trying to understand when and how you will update the biosdevname version. Can you please let us know.

[Rafael David Tinoco (rafaeldtinoco)]

Note that, differently from what was request in the BUG description, I can't back port newer version to LTS Ubuntu Versions. I have to find commits that were responsible for fixing erratic behaviour and make sure all versions are fixed and, possibly, work together with the core team to upstream version for Willy (Ubuntu development version nowadays).

Could you please provide:

- Server Type
- HBA Type
- Kernel Version

I could NOT reproduce this behaviour in a Proliant server with "mlx4_en: Mellanox ConnectX HCA Ethernet driver v2.2-1 (Feb 2014)". So I'll rely on feedbacks in this case for proposing the SRU.

For now I have back-ported the following upstream commits:

commit 47da4e4e399c7455b282e3dae03de28519dcb166
Author: Jordan Hargrave <email address hidden>
Date: Tue Sep 23 09:51:10 2014 -0500

    Add dev_port attribute for new Mellanox driver

commit c140ce659a204d67e4cc61d2191443123f7dd970
Author: Jordan Hargrave <email address hidden>
Date: Mon Mar 3 11:06:44 2014 -0600

    Add port code for Mellanox driver

commit f3e6790b7986a4f9dd4a407901717ef8de3cbbc6
Author: Jordan Hargrave <email address hidden>
Date: Tue Feb 25 16:35:40 2014 -0600

    Add port structure to PCI device, handle multiple ports per BDF (Mellanox)

commit cee3f7b101fb22540e2f92067a5c49d3f817e441
Author: Jordan Hargrave <email address hidden>
Date: Tue Feb 25 15:51:50 2014 -0600

    Scan for devid for Mellanox cards

commit 70d82c269a335cf8f781f347b3708283d63ce213
Author: Jordan Hargrave <email address hidden>
Date: Wed Oct 16 15:12:06 2013 -0500

    Stop reading VPD data once VPD-R section has been read
    Mellanox cards were taking too long to read entire VPD

AND Will inform a PPA to be tested soon.

Thank you

Rafael Tinoco

[Rafael David Tinoco (rafaeldtinoco)]

I have made available one PPA with the fixes I highlighted above:

https://launchpad.net/~inaddy/+archive/ubuntu/lp1455871

* Instructions how to enable it:

inaddy@tmellanoxbiosdev:~$ sudo apt-get update
inaddy@tmellanoxbiosdev:~$ sudo apt-get dist-upgrade
inaddy@tmellanoxbiosdev:~$ sudo apt-get install software-properties-common
inaddy@tmellanoxbiosdev:~$ sudo add-apt-repository ppa:inaddy/lp1455871
inaddy@tmellanoxbiosdev:~$ sudo apt-get update
inaddy@tmellanoxbiosdev:~$ sudo apt-get install biosdevname

Please provide feedback.

Thank you

Rafael Tinoco

[Warren Wang (w-emailme)]

I can confirm this bug, as an end user of the Mellanox cards and Ubuntu Trusty with the default biosdevname. The second port is, for all intents and purposes, unusable, since the logical name would change on every reboot. biosdevname .6.2 fixed the issue.

Supermicro SuperServer 6047R-E1R72L
Mellanox ConnectX-3 Pro, 2* 40Gbe
Ubuntu Trusty, 3.13.0-52-generic

[Rafael David Tinoco (rafaeldtinoco)]

Warren, sorry it was unclear to me if you tried the hotfix from PPA or not.

[Gideon Naim (gideonn)]

Rafael,

I have followed the upgrade steps and it fixes the issue. Thank you for fixing it.

Gidi

BIOS device: p4p1
Kernel name: p4p1
Permanent MAC: F4:52:14:33:D2:11
Assigned MAC : F4:52:14:33:D2:11
ifIndex: 8
Driver: mlx4_en
Driver version: 2.2-1 (Feb 2014)
Firmware version: 2.34.5000
Bus Info: 0000:86:00.0
PCI name : 0000:86:00.0
PCI Slot : 4
SMBIOS Label: PCI-Express Slot 4
Index in slot: 1

BIOS device: p4p2
Kernel name: p4p2
Permanent MAC: F4:52:14:33:D2:12
Assigned MAC : F4:52:14:33:D2:12
ifIndex: 9
Driver: mlx4_en
Driver version: 2.2-1 (Feb 2014)
Firmware version: 2.34.5000
Bus Info: 0000:86:00.0
PCI name : 0000:86:00.0
PCI Slot : 4
SMBIOS Label: PCI-Express Slot 4
Index in slot: 1

[Rafael David Tinoco (rafaeldtinoco)]

I’m glad to hear that. I’ll work on providing the fixes for Trusty, Utopic, Vivid and Wily. Then I’ll ask for sponsorship for this bug to be uploaded to -proposed. This will probably happen tomorrow.

Thank you

-Rafael Tinoco

[James Saint-Rossy (james-saintrossy)]

+1. Installed using the PPA and upgraded to Version: 0.4.1-0ubuntu6.2~lp1455871~1.

Thanks, James.

BIOS device: p6p1
Kernel name: p6p1
Permanent MAC: F4:52:14:57:F1:20
Assigned MAC : F4:52:14:57:F1:20
ifIndex: 6
Driver: mlx4_en
Driver version: 2.2-1 (Feb 2014)
Firmware version: 2.32.5100
Bus Info: 0000:04:00.0
PCI name : 0000:04:00.0
PCI Slot : 6
SMBIOS Label: CPU1 Slot6 PCI-E 3.0 x8
Index in slot: 1

BIOS device: p6p2
Kernel name: p6p2
Permanent MAC: F4:52:14:57:F1:21
Assigned MAC : F4:52:14:57:F1:21
ifIndex: 7
Driver: mlx4_en
Driver version: 2.2-1 (Feb 2014)
Firmware version: 2.32.5100
Bus Info: 0000:04:00.0
PCI name : 0000:04:00.0
PCI Slot : 6
SMBIOS Label: CPU1 Slot6 PCI-E 3.0 x8
Index in slot: 1

[Rafael David Tinoco (rafaeldtinoco)]

Subscribing Sponsors and Asking for Sponsorship

[Rafael David Tinoco (rafaeldtinoco)]

Fix for Trusty.

[Rafael David Tinoco (rafaeldtinoco)]

Fix for Utopic.

[Rafael David Tinoco (rafaeldtinoco)]

Fix for Vivid.

[Rafael David Tinoco (rafaeldtinoco)]

Fix for Wily.

[Jared Dominguez (jared-dominguez)]

Uh, you realize that Debian doesn't have biosdevname, right?

[Rafael David Tinoco (rafaeldtinoco)]

Now I do ;)

[Launchpad Janitor (janitor)]

This bug was fixed in the package biosdevname - 0.4.1-0ubuntu8

---------------
biosdevname (0.4.1-0ubuntu8) wily; urgency=medium

  * Added upstream Mellanox fixes to biosdevname per their request: (LP: #1455871)
      + d/p/Stop-reading-VPD-data-once-VPD-R-section-has-been-re.patch
      + d/p/Scan-for-devid-for-Mellanox-cards.patch
      + d/p/Add-port-structure-to-PCI-device-handle-multiple-por.patch
      + d/p/Add-port-code-for-Mellanox-driver.patch
      + d/p/Add-dev_port-attribute-for-new-Mellanox-driver.patch

 -- Rafael David Tinoco (Inaddy) <email address hidden> Thu, 23 Jul 2015 10:34:32 -0500

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Nobuto Murata (nobuto)]

I've also confirmed that the second port is properly recognized with the trusty SRU patchset.

product: MT27520 Family [ConnectX-3 Pro]
vendor: Mellanox Technologies
====
BIOS device: p1p2
Kernel name: eth5
Permanent MAC: E4:1D:2D:74:16:B1
Assigned MAC : E4:1D:2D:74:16:B1
ifIndex: 7
Driver: mlx4_en
Driver version: 2.2-1 (Feb 2014)
Firmware version: 2.32.5100
Bus Info: 0000:08:00.0
PCI name : 0000:08:00.0
PCI Slot : 1
SMBIOS Label: PCI-E Slot 1
Index in slot: 1
====

[Rafael David Tinoco (rafaeldtinoco)]

I changed it to In Progress so Sponsors com upload my patches for Trusty and Vivid.

[Gideon Naim (gideonn)]

Who can we and other customers become sponsors for Trusty and Vivid?

[Rafael David Tinoco (rafaeldtinoco)]

Gideon,

I already spoke with a Sponsor (~arges) and this will be uploaded to -proposed soon.

Thank you

[Rafael David Tinoco (rafaeldtinoco)]

Somehow I think I missed subscribing sponsors team to this bug. I still need fix for Trusty and Vivid.

[Timo Aaltonen (tjaalton)]

Hello Kamal, or anyone else affected,

Accepted biosdevname into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/biosdevname/0.4.1-0ubuntu7.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Timo Aaltonen (tjaalton)]

Hello Kamal, or anyone else affected,

Accepted biosdevname into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/biosdevname/0.4.1-0ubuntu6.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Rafael David Tinoco (rafaeldtinoco)]

Nobuto, regarding case:

https://bugs.launchpad.net/ubuntu/+source/biosdevname/+bug/1455871

Could you ask user to provide verification on “-proposed” ?

Thank you

Rafael Tinoco

[Nobuto Murata (nobuto)]

Today I had a change to access to the Mellanox board luckily. Here is a result of verification:

[0.4.1-0ubuntu6.1/trusty-updates]
BIOS device: <-- no name
Kernel name: eth5
Permanent MAC: F4:52:14:XX:XX:XX
Assigned MAC : F4:52:14:XX:XX:XX
ifIndex: 6
Driver: mlx4_en
Driver version: 2.2-1 (Feb 2014)
Firmware version: 2.34.5000
Bus Info: 0000:0a:00.0

[0.4.1-0ubuntu6.2/trusty-proposed]
BIOS device: p1p2 <-- properly named
Kernel name: eth5
Permanent MAC: F4:52:14:XX:XX:XX
Assigned MAC : F4:52:14:XX:XX:XX
ifIndex: 6
Driver: mlx4_en
Driver version: 2.2-1 (Feb 2014)
Firmware version: 2.34.5000
Bus Info: 0000:0a:00.0
PCI name : 0000:0a:00.0
PCI Slot : 1
SMBIOS Label: PCI-E Slot 1
Index in slot: 1

[Nobuto Murata (nobuto)]

> Today I had a change to access to the Mellanox board luckily. Here is a result of verification:

correction: "I had a chance to access".

[Rafael David Tinoco (rafaeldtinoco)]

Thank you Nobuto. I got confirmation from Mellanox that this issue is fixed. Verification-Done. Waiting on Fix Release.

[Launchpad Janitor (janitor)]

This bug was fixed in the package biosdevname - 0.4.1-0ubuntu6.2

---------------
biosdevname (0.4.1-0ubuntu6.2) trusty; urgency=medium

  * Added upstream Mellanox fixes to biosdevname per their request: (LP: #1455871)
      + d/p/Stop-reading-VPD-data-once-VPD-R-section-has-been-re.patch
      + d/p/Scan-for-devid-for-Mellanox-cards.patch
      + d/p/Add-port-structure-to-PCI-device-handle-multiple-por.patch
      + d/p/Add-port-code-for-Mellanox-driver.patch
      + d/p/Add-dev_port-attribute-for-new-Mellanox-driver.patch

 -- Rafael David Tinoco (Inaddy) <email address hidden> Tue, 01 Sep 2015 11:50:38 -0500

[Chris J Arges (arges)]

The verification of the Stable Release Update for biosdevname has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package biosdevname - 0.4.1-0ubuntu7.1

---------------
biosdevname (0.4.1-0ubuntu7.1) vivid; urgency=medium

  * Added upstream Mellanox fixes to biosdevname per their request: (LP: #1455871)
      + d/p/Stop-reading-VPD-data-once-VPD-R-section-has-been-re.patch
      + d/p/Scan-for-devid-for-Mellanox-cards.patch
      + d/p/Add-port-structure-to-PCI-device-handle-multiple-por.patch
      + d/p/Add-port-code-for-Mellanox-driver.patch
      + d/p/Add-dev_port-attribute-for-new-Mellanox-driver.patch

 -- Rafael David Tinoco (Inaddy) <email address hidden> Tue, 01 Sep 2015 11:53:11 -0500