Comment 19 for bug 607291

On Friday 10,December,2010 02:08 AM, Michael Terry wrote:
> libkarma is kind of a mess.
>
> * lintian messages:
>
> E: libkarma source: patch-modifying-debian-files 20_install_playlist_show_as_example.dpatch debian/libkarma-dev.examples
> W: libkarma source: patch-system-but-no-source-readme
> W: libkarma source: patch-system-but-direct-changes-in-diff tools/karma_helper.c
> W: libkarma source: debhelper-but-no-misc-depends libkarma-dev
> W: libkarma source: out-of-date-standards-version 3.8.0 (current is 3.9.1)
> W: libkarma-cil: wrong-section-according-to-package-name libkarma-cil => cli-mono
> W: libkarma-cil-dev: wrong-section-according-to-package-name libkarma-cil-dev => libdevel
>
> * A watch file (and homepage setting) that 404s
>
> * No symbols file or -V arg to dh_makeshlibs
>
> * Bug 296737 seems bad
>
> * New upstream version available but unpackaged for 3 and a half years
>
> * A bad memcpy and strncat for amd64:
>
> In file included from /usr/include/string.h:642:0,
> from karmaLan.c:18:
> In function ‘memcpy’,
> inlined from ‘lk_karmaLan_get_protocol_version’ at karmaLan.c:198:11:
> /usr/include/bits/string3.h:52:3: warning: call to __builtin___memcpy_chk will always overflow destination buffer
>
> * Lots of errors like the following representative sample:
>
> properties.c:350:18: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
> properties.c:296:9: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result
> mp3.c:206:18: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result
> riocp.c:652:22: warning: ignoring return value of ‘scanf’, declared with attribute warn_unused_result
> karma.c:49:5: warning: ISO C90 forbids specifying subobject to initialize
>
> * And to top it off, upstream no longer has a working Karma and is
> looking for a new maintainer, so no new fixes from that direction.
>
> Since neither upstream nor Debian are very active in this package, it
> looks like we'd be on our own. And there is definitely work to be done
> for this one. Is it necessary for banshee?

I could probably take care of bringing the package up to date, at least to the
latest upstream version (though after the 16th, when my exams end).

As for whether it's necessary, I doubt anyone would notice if we dropped support
for Rio Karma players, considering that it was left broken for a number of
months (or even years, who knows) due to a missing .pc file and Banshee's build
system silently disabling Karma support when it didn't detect the .pc file.

It would be a nice touch to have though, for anyone who happens to discover an
old Rio Karma lying around and wanting to sync music to it. I don't have one,
but I hear it was pretty awesome during its time.

--
Kind regards,
Loong Jin