Bionic rev 7906 fails to build against v5.4 kernels, error: linux/pci-aspm.h: No such file or directory

[You-Sheng Yang]

[SRU Justification]

[Impact]
Systems with backport-iwlwifi-dkms installed (probably via modaliases match) may fails dkms trigger when installing kernel packages due to the lack of support to v5.4 kernel or newer.

[Fix]
Commits 7c0210bec6c0 ("backport: add pci-aspm.h to backport pci.h") and commit dcb781ec6656 ("iwlwifi: pcie: remove pci-aspm.h include") from https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/backport-iwlwifi.git

[Test Case]
Install v5.4 kernel header packages and backport-iwlwifi-dkms in Bionic. DKMS should be built (but not installed to /lib/modules) successfully with no error.

Tested agaist following kernels:
* 4.15.0-109-generic
* 4.15.0-1091-oem
* 4.18.0-25-generic
* 5.0.0-1063-oem-osp1
* 5.0.0-53-generic
* 5.3.0-62-generic
* 5.4.0-40-generic

[Regression Potential]
Low. We've previously added OBSOLETE_BY=5.0.0 to dkms config in bug 1859389, but that won't stop it from compiling against new kernels, but only skips built modules installation. So this doesn't affect any existing system but to fix build error only.

========== Original Bug Description ==========

With v5.4 kernel backported into Bionic, now backport-iwlwifi-dkms may need corresponding updates to be able to build against v5.4 kernel.

[You-Sheng Yang (vicamo)]

In theory this may also happen on Eoan as it has rev 7906 as well, but since there is no plan to backport 5.4 kernel into Eoan, marking it as WONTFIX instead.

[You-Sheng Yang (vicamo)]

PPA for verification: https://launchpad.net/~vicamo/+archive/ubuntu/ppa-1886911

[You-Sheng Yang (vicamo)]

This needs review and upload to Ubuntu archive.

[Brian Murray (brian-murray)]

Hello You-Sheng, or anyone else affected,

Accepted backport-iwlwifi-dkms into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/7906-0ubuntu4~18.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[You-Sheng Yang (vicamo)]

Verified 7906-0ubuntu4~18.04.2 from bionic-proposed against following kernels:
* 4.15.0-1093-oem
* 4.15.0-112-generic
* 4.18.0-25-generic
* 5.0.0-1065-oem-osp1
* 5.0.0-53-generic
* 5.3.0-62-generic
* 5.4.0-42-generic

[Launchpad Janitor (janitor)]

This bug was fixed in the package backport-iwlwifi-dkms - 7906-0ubuntu4~18.04.2

---------------
backport-iwlwifi-dkms (7906-0ubuntu4~18.04.2) bionic; urgency=medium

  * Fix build against v5.4 kernel (LP: #1886911)

 -- You-Sheng Yang <email address hidden> Thu, 09 Jul 2020 14:37:35 +0800

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for backport-iwlwifi-dkms has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.