Comment 19 for bug 1026852

Revision history for this message
Tyler Hicks (tyhicks) wrote :

Here's the (large) debdiff that fixes the important compiler warnings. I've submitted all three patches upstream:

https://www.redhat.com/archives/linux-audit/2013-February/msg00003.html

There are still remaining compiler warnings, but I consider them to be ok:

../../../../src/libev/ev.c:1254:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern' [enabled by default]
../../../../src/libev/ev.c: In function 'pipecb':
../../../../src/libev/ev.c:1900:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
../../../../src/libev/ev.c:1907:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]

The ev_default_loop_ptr issue is intentional considering this comment on the line triggering the warning:

/* needs to be initialised to make it a definition despite extern */

The ignored return value of 'read' is ok because the function is just slurping a few bytes off of a signal pipe into a dummy buffer, which is ignored. There is no error handling or logging to be done in this situation, even if read() failed.

There are still a number of compiler warnings in the zos-remote audispd plugin. Most of them are harmless warnings, but the main reason why I feel they can be ignored is because the audisp-plugins package is remaining in universe.