Comment 0 for bug 1671767

asterisk 1:13.1.0~dfsg-1.1ubuntu4

lsb_release -rd:
Description: Ubuntu 16.04.2 LTS
Release: 16.04

Bug details:
============
when dialing a h264 video sip device (Grandstream GXV3674_FHD_VF 1.0.3.17) asterisk crashes with a core dump:

Connected to Asterisk 13.1.0~dfsg-1.1ubuntu4 currently running on samson (pid = 29051)
samson*CLI> console dial waldorf@Phones
    -- Executing [waldorf@Phones:1] Dial("Console/default", "SIP/waldorf,60") in new stack
  == Using SIP VIDEO CoS mark 6
  == Using SIP RTP CoS mark 5
    -- Called SIP/waldorf
    -- SIP/waldorf-00000000 is ringing
samson*CLI>
Disconnected from Asterisk server
Asterisk cleanly ending (0).
Executing last minute cleanups

Analysis:
=========
gdb reveals that the module "res_format_attr_h264.so" is resposible due to a memory allocation failure while examining tokens of the "sprop-parameter-sets" string in the SIP header.

Proposed Solution:
==================
This bug is already fixed by 2 small patches included in a more recenent versions of "res/res_format_attr_h264.c"

https://issues.asterisk.org/jira/browse/ASTERISK-24616
Crash in res_format_attr_h264 due to invalid string copy

https://issues.asterisk.org/jira/browse/ASTERISK-25573
[patch] H.264 format attribute module: resets whole SDP

This fixed version of "res/res_format_attr_h264.c" is included e.g. in asterisk (1:13.13.1~dfsg-4ubuntu1) zesty.

Fixed+Tested:
=============
I tested by rebuiling asterisk 1:13.1.0~dfsg-1.1ubuntu4 packages with the "res/res_format_attr_h264.c" taken from asterisk 1:13.13.1~dfsg-4ubuntu1 and could connect to the sip device without any problems.

I would be great, if you could add this patch into asterisk 1:13.1.0~dfsg-1.1ubuntu4, since I don't want to use self built debs on a 16.4 LTS production system.

Thanks a lot
Jörg