Ubuntu
asterisk-espeak package

  1. Bug #2051908
  2. Comment #5

Comment 5 for bug 2051908

Revision history for this message
Paride Legovini (paride) wrote :

Hello and thanks for submitting this patch both here and to Debian. I have some comments/questions about it:

1. Do we actually need to keep the upstream way to detect ASTLIBDIR when $(ASTMODDIR) is not set? I'm speaking of:

+ifeq ($(ASTMODDIR),)
+ ASTLIBDIR:=$(shell awk '/moddir/{print $$3}' /etc/asterisk/asterisk.conf 2> /dev/null)

Maybe in the context of the Debian package we can just assume $ASTMODDIR is set from d/rules.

2. You mentioned that the issues comes from the fact that asterisk-config isn't a build-dep, and "rightly so". Is there any issue in installing asterisk-config as a build-dep? That will allow auto-detecting ASTLIBDIR with the upstream logic.

3. If you're keeping the d/patches patch, please add full dep-3 headers (https://dep-team.pages.debian.net/deps/dep3/), but I really suggest exploring the solution above.